- Issue created by @markdorison
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 5:06pm 22 November 2023 - 🇮🇳India ankithashetty Karnataka, India
Only seeing the following errors, which are addressed in the MR:
$ phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .
FILE: /sfweb2lead_webform/src/Plugin/WebformHandler/SalesforceWebToLeadPostWebformHandler.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 41 | ERROR | The array declaration extends to column 115 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------- FILE: /sfweb2lead_webform/src/EventSubscriber/BackwardsCompatibilitySubscriber.php --------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------- 29 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 42 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------
Please review, Thanks!
-
markdorison →
committed b1f355e9 on 6.x authored by
ankithashetty →
Issue #3400252: Resolve PHPStan warnings found in GitLab CI runs
-
markdorison →
committed b1f355e9 on 6.x authored by
ankithashetty →
- Status changed to Fixed
over 1 year ago 9:03pm 24 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.