[GitlabCI] run-tests.sh does not pass on SYMFONY_DEPRECATIONS_HELPER environment variable value to spawned processes

Adding context as per why this issue is in core.
The environment variable is there and is defined, but it just seems to be ignored by "run-tests.sh" script.

It might be related to the same reason why we need to pass the "mink" variables in GitLab CI (and DrupalCI).
sudo MINK_DRIVER_ARGS_WEBDRIVER="$MINK_DRIVER_ARGS_WEBDRIVER" ...

I think this is because we use sudo to run the tests as www-data and it doesn't pass on env vars by default. I think we have three options:

1. Add SYMFONY_DEPRECATIONS_HELPER to the sudo line alongside MINK_DRIVER_ARGS_WEBDRIVER
2. Switch to using sudo -E to pass all environment variables down
3. Stop using sudo entirely, we are in throwaway containers so does it matter if the tests run as root?

#4.3 sounds reasonable to me. In my scripts on GHA I call the executables straight away with no issues.

#4.2 is in fact what is currently being done when running PHPUnit CLI, but not when running run-tests.sh.

Now that we know the exact reason for the issue, I think the fix actually belongs to the "GitLab Templates" project, so moving there where I can take care of it.

Thanks for creating the issue and for the quick response.

I went with option 2 suggested in #4, purely because it was easier. Ideally we can do 3 but I'd probably do it in a separate issue and make sure that both contrib and core use it this way.

MR is here for review: https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/82/...

You can test adding this to your .gitlab-ci.yml file:

  - project: issue/gitlab_templates-3400218
    ref: 3400218-env-variables-to-phpunit

Core has some separate jobs that use sudo so we will need a duplicate issue over there.

Tried option 3 from #4 but that somehow required the sudo password and didn't work: https://git.drupalcode.org/project/image_effects/-/pipelines/46377

I went with option 1 from #4 and that worked well:
- Non concurrent: https://git.drupalcode.org/issue/image_effects-3400245/-/pipelines/46587
- Concurrent: https://git.drupalcode.org/issue/image_effects-3400245/-/pipelines/46608

So, for this issue, I’m going with the minimum changes to make it work and then I’ll create a follow-up issue to try to remove sudo altogether. Once we achieve that here we can do the same for core (one issue at a time).

This one is still ready for review.

Child issue ✨ Do not run commands as other user as we lose env variables Active

Yep, it works, thanksa lot @fjgarlin!

Minimum change here, removal of sudo usage is bigger story.

Merged and marked as fixed! Thanks for reporting and for the suggestions.

AFAICT this did not actually work? See #3400979-11: Is SYMFONY_DEPRECATIONS_HELPER: weak correct for contrib deprecation testing needs? → .

I commented on the other issue. The fix here did work (see the line I linked where we see the command being run as an output line), but the value passed wasn't probably the right one "weak", which is exactly what the other issue is about.

Automatically closed - issue fixed for 2 weeks with no activity.