Do not run commands as other user as we lose env variables

Running as root could silently hide a few disk access related flaws:

$BLANK='';
mkdir("$BLANK/test_dir");

would succeed if running as root, but (likely) fail as www-data.

https://www.drupal.org/docs/automated-testing/phpunit-in-drupal/running-... → calls for using the -E flag.

That's a good point and a great argument to keep using www-data user.

Note that we tried on the mentioned issue the use of -E but that did not work (see this comment 🐛 [GitlabCI] run-tests.sh does not pass on SYMFONY_DEPRECATIONS_HELPER environment variable value to spawned processes Fixed ).

That's exactly why I created this issue as follow-up. I did the quick fix for the other one and then decide on approach and investigation on this one.

I'm happy with whatever makes the most sense. The -E seems to be the less intrusive, but we need to make it work without requiring the sudo password.

Test run started:
  Wednesday, November 8, 2023 - 19:35
Test summary
------------
We trust you have received the usual lecture from the local System
Administrator. It usually boils down to these three things:
    #1) Respect the privacy of others.

To me this looks likely the script might have been ran (successfully) as www-data and inside it tried to sudo again since we don't appear to output any of that text as part of the Gitlab templates.

The 36 counts of sudo: a password is required implies it happened for each and every "Test to be run" listed and not just the parent run.

Good catch. So we might need to also alter something inside "run-tests.sh" to get this to work.

Trying again the -E flag in 🐛 BROWSERTEST_OUTPUT_VERBOSE is not passed to run-tests.sh when running with it Active didn't work. Then an alternative solution was suggested. I suggest that we leave that fix as it will solve the env variables issue and that we maybe use this issue to have it behind a flag that can be turn on/off as needed .

I'll close this in favour of the other one.