Fix the errors of phpstan (6) (aws_cloud)

Issue created by @xiaohua guan
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
@xiaohua-guan opened merge request.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Status changed to Needs review over 1 year ago8:45am 8 November 2023
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan

🇺🇸United States yas California 🇺🇸

@xiaohua-guan

Thank you for the refactoring. Can you rebase the patch? Also, can you please include the following warning fixes?

$ phpstan analyze .

...

------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/cloud_service_providers/aws_cloud/tests/src/Unit/Plugin/cloud/launch_template/AwsCloudLaunchTemplatePluginTest.php  
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  70     Missing call to parent::setUp() method.                                                                                     
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

...

 ------ ----------------------------------------------------------------------------------------- 
  Line   modules/cloud_service_providers/aws_cloud/tests/src/Unit/Service/Ec2/Ec2ServiceTest.php  
 ------ ----------------------------------------------------------------------------------------- 
  117    Missing call to parent::setUp() method.                                                  
 ------ ----------------------------------------------------------------------------------------- 

...

Thanks!

Status changed to Needs work over 1 year ago11:22pm 8 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Status changed to Needs review over 1 year ago1:50am 9 November 2023
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
@yas

Thanks for your comment. I've rebased the code. And also I fixed the code. Please take a look again. Thanks.
Status changed to RTBC over 1 year ago5:58am 9 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Comment over 1 year ago →
System Message

yas → committed 591709df on 6.x authored by Xiaohua Guan →
Issue #3399993 by Xiaohua Guan, yas: Fix the errors of phpstan (6) (...
Status changed to Fixed over 1 year ago5:59am 9 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Status changed to Needs review over 1 year ago9:32am 10 November 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
@yas

I added a hotfix. Please take a look. Thanks.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
@xiaohua-guan opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Status changed to RTBC over 1 year ago9:55pm 10 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@xioahua-guan

Thank you for the hotfix. I have ran the PHPUnit tests several times and it looks good. I'll merge the patch to 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Comment over 1 year ago →
System Message

yas → committed cfe13b54 on 6.x authored by Xiaohua Guan →
Issue #3399993 by Xiaohua Guan, yas: Hotfix - Fix the errors of phpstan...
Status changed to Fixed over 1 year ago10:31pm 10 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the errors of phpstan (6) (aws_cloud)

Problem/Motivation

Comments & Activities