- Issue created by @sonfd
- last update
about 1 year ago 9 pass - @sonfd opened merge request.
- Status changed to Needs review
about 1 year ago 1:24pm 7 November 2023 - 🇮🇳India Raveen Kumar
@Hello Guys
To rectify this issue, we should check and make sure that the "separator" key exists in the $settings array before attempting to access its nested "day_hours" key. This can be done using the isset() or array_key_exists() functions to verify the existence of the "separator" key before accessing its nested keys.
Something like this
if (isset($settings['separator'])) {
$days_suffix = $settings['separator']['day_hours'];
} else{
} - Status changed to Fixed
about 1 year ago 2:55pm 7 November 2023 - 🇳🇱Netherlands johnv
Hmm, this is a regression issue. There is also another use case with the same problem.
I cannot find why/when this happened.Anyway, I took another approach then you both. Please take a look at the committed, attached patch.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 7:56pm 28 November 2023 - 🇺🇸United States john.oltman
Reroll against 8.x-1.12 release instead of dev