Fix strict type errors in functional JavaScript tests

MR 5296 contains the results of adding strict type to the all the tests and the fixes you made in MR 5273. Gitlab is faster then my local but all green.

FWIW (I didn't make it clear) but the earlier commits in the MR will demonstrate all the fails and all the fixes. MR 5296 is good verification that the fixes resolve all the issues. Once this is committed we can move over to 📌 Add declare(strict_types=1) to all Functional JavaScript tests Fixed .

So should it be in review or rtbc?

Didn't mean to change the status.

Nice work on this.

There are any number of unnecessary sprintf() calls being added where we can just embed the variables in the string. It seems nowadays array values don't even require {} anymore also. Also one place where the comparison operator should probably be improved to go along with this.

Thanks!

Thanks for the review, these have all been addressed. I'm not sure about removing the {} from array values, it doesn't work in https://3v4l.org/nk9So unless I remove the single quotes as well in https://3v4l.org/iaBCO, which my IDE didn't like.

Seems sprintf have been removed

#12 is interesting!

These changes work for me. Also I forgot to mention before that the comments on the MR explaining the specific changes were quite helpful; thanks for those.

Saving credits.

Committed to 11.x, 10.2.x, and 10.1.x as a test improvement. Thanks!

xjm → closed merge request !5273

Automatically closed - issue fixed for 2 weeks with no activity.