Issues reported by PHPStan

Hi @bluegeek9
i have fixed the issue and added a patch , please review.
Thanks

Hi,

We are extending MessageController class to get extra functionality. The recent update from 8.x-1.0 to 8.x-1.1 is causing code to break because all the classes have been declared final.

Code changed from

`class MessageController extends ControllerBase implements ContainerInjectionInterface {`

to

`final class MessageController extends ControllerBase implements ContainerInjectionInterface {`

Is there a reason for this API-breaking change? It seems unnecessarily strict to prevent these classes from being overridden.

Are you overriding the constructor? I am inclined to leave the change.

We're extending the class, but we are not overriding the constructor. We're extending the class in order to get more functionality out of it. I think one of the big reasons that Drupal moved to an OO structure is to allow extending classes like this.

I can submit patches to add that functionality to MessageController if you're friendly to that. I've already added one such patch in #3403215.

Is there a good reason to declare these classes final? I don't understand the logic behind that.

Hi @dtarc,

I don't understand what functionality you are getting by inheriting MessageController. Why are you not inheriting ControllerBase?

bluegeek9 → closed merge request !13

@dtarc,

I made the constructor final instead of the class.