Issues reported by PHPStan

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$? ------ ------------------------------------------------------------------------------ Line modules/message_notify_ui/src/Form/MessageNotifyForm.php ------ ------------------------------------------------------------------------------ 125 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------------------------------------------ Line modules/message_notify_ui/src/Plugin/MessageNotifyUiSenderSettingsForm/MessageNotifyUiSenderMailSettingsForm.php ------ ------------------------------------------------------------------------------------------------------------------ 70 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------------------------------------- Line modules/message_notify_ui/src/Plugin/MessageUiViewsContextualLinks/MessageUiContextualLinkNotifyMessage.php ------ ------------------------------------------------------------------------------------------------------------- 81 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line src/Controller/MessageController.php ------ ------------------------------------------------------------------------------ 45 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/DeleteMultiple.php ------ ------------------------------------------------------------------------------ 104 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Form/MessageMultipleDeleteForm.php ------ ------------------------------------------------------------------------------ 49 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ------------------------------------------------------------------------------ ------ ---------------------------------------------------------------------- Line src/MessageAccessControlHandler.php ------ ---------------------------------------------------------------------- 79 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ --------------------------------------------------------------------- Line src/MessageUiViewsContextualLinksBase.php ------ --------------------------------------------------------------------- 24 Method Drupal\message_ui\MessageUiViewsContextualLinksBase::setMessage() should return Drupal\message_ui\MessageUiViewsContextualLinksInterface but return statement is missing. ------ --------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line src/Plugin/MessageUiViewsContextualLinks/MessageUiContextualLinkDeleteMessage.php ------ ----------------------------------------------------------------------------------- 70 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------- Line src/Plugin/MessageUiViewsContextualLinks/MessageUiContextualLinkEditMessage.php ------ --------------------------------------------------------------------------------- 70 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ --------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------- Line src/Plugin/MessageUiViewsContextualLinks/MessageUiContextualLinkViewMessage.php ------ --------------------------------------------------------------------------------- 70 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ --------------------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src/Plugin/QueueWorker/MessageArgumentsWorker.php ------ ---------------------------------------------------------------------- 27 \Drupal calls should be avoided in classes, use dependency injection instead 50 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line src/Plugin/views/field/MessageUIContextualLinks.php ------ ---------------------------------------------------------------------- 36 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- [ERROR] Found 14 errors

Comments & Activities

Issue created by @bluegeek9
First commit to issue fork.
Status changed to Needs review about 1 year ago11:39am 7 November 2023
Comment about 1 year ago →
🇮🇳India viren18febS
Hi @bluegeek9
i have fixed the issue and added a patch , please review.
Thanks
Merge request !13Issue #3399697 by viren18febS: Issues reported by PHPStan → (Closed) created by bluegeek9
Status changed to Needs work 12 months ago11:38pm 17 November 2023
Comment 12 months ago →
🇺🇸United States bluegeek9
@bluegeek9 opened merge request.
Pipeline finished with Skipped
12 months ago
#51936
Comment 12 months ago →
System Message

bluegeek9 → committed cbcd785e on 8.x-1.x
Issue #3399697 by bluegeek9: Issues reported by PHPStan
Status changed to Active 12 months ago11:57pm 17 November 2023
Comment 12 months ago →
🇺🇸United States bluegeek9
Merge request !15Resolve #3399697 "Dependency injection" → (Merged) created by bluegeek9
Comment 12 months ago →
🇨🇦Canada dtarc
Hi,

We are extending MessageController class to get extra functionality. The recent update from 8.x-1.0 to 8.x-1.1 is causing code to break because all the classes have been declared final.

Code changed from

`class MessageController extends ControllerBase implements ContainerInjectionInterface {`

to

`final class MessageController extends ControllerBase implements ContainerInjectionInterface {`

Is there a reason for this API-breaking change? It seems unnecessarily strict to prevent these classes from being overridden.
Comment 12 months ago →
🇺🇸United States bluegeek9
Are you overriding the constructor? I am inclined to leave the change.
Comment 12 months ago →
🇨🇦Canada dtarc
We're extending the class, but we are not overriding the constructor. We're extending the class in order to get more functionality out of it. I think one of the big reasons that Drupal moved to an OO structure is to allow extending classes like this.

I can submit patches to add that functionality to MessageController if you're friendly to that. I've already added one such patch in #3403215.

Is there a good reason to declare these classes final? I don't understand the logic behind that.
Comment 12 months ago →
🇺🇸United States bluegeek9
Hi @dtarc,

I don't understand what functionality you are getting by inheriting MessageController. Why are you not inheriting ControllerBase?
Comment 10 months ago →
System Message
bluegeek9 → closed merge request !13
Pipeline finished with Skipped
10 months ago
#81553
Comment 10 months ago →
System Message

bluegeek9 → committed 3273c236 on 8.x-1.x
Issue #3399697 by bluegeek9, viren18febS: Issues reported by PHPStan
Comment 10 months ago →
🇺🇸United States bluegeek9
@dtarc,

I made the constructor final instead of the class.
Merge request !22Resolve #3399697 "Additional" → (Merged) created by bluegeek9
Pipeline finished with Skipped
about 2 months ago
#291539
Comment about 2 months ago →
System Message

bluegeek9 → committed 3d722135 on 8.x-1.x
Issue #3399697 by bluegeek9, viren18febs: Issues reported by PHPStan
Comment about 2 months ago →
🇺🇸United States bluegeek9
Comment about 1 month ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!22Issues reported by PHPStan
Merged

!15Issues reported by PHPStan
Merged

!13Issues reported by PHPStan
Closed

Comments & Activities

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!22Issues reported by PHPStanMerged

!15Issues reported by PHPStanMerged

!13Issues reported by PHPStanClosed

Comments & Activities

!22Issues reported by PHPStan
Merged

!15Issues reported by PHPStan
Merged

!13Issues reported by PHPStan
Closed