- Issue created by @anjor.rao
- Status changed to Postponed: needs info
over 1 year ago 4:47pm 6 November 2023 - π¨πSwitzerland saschaeggi Zurich
Can you check if this problem also appears in Claro? Maybe you're using AvgAgg? AvgAgg has some abandoned CSS & JS processors which can break Claro & Gin (JSqueeze for example).
- π¨π¦Canada anjor.rao
I checked the issue in the Claro theme, and the File browser is visible. As for AvgAgg, I am not using this module.
- π¨πSwitzerland saschaeggi Zurich
Then I'd look out for any JS errors on the site
- π¨π¦Canada anjor.rao
Hello, I've attached a screenshot. Could you please take a look? I tried checking if the Coffee module was causing any issues, but that doesn't seem to be the case. Additionally, I didn't see any JS errors on the Claro theme. Should I create an issue in the core project?
- π¨πSwitzerland saschaeggi Zurich
Can you expand the error messages so we can see where in the code the error occurs? TY
- πΊπΈUnited States jon.lund
I can confirm that I am experiancing the same issue. When js aggrigation is turned on imce browser does not render. This only happens with Gin as the Admin Theme, it does not happen in either Claro or Olivero.
Drupal 10.1.6 Gin 8.x-3.0-rc7 IMCE 3.0.9
- π¨π¦Canada anjor.rao
Hello,
Please find the attached files. Let me know if you need more information.
- π¨πSwitzerland saschaeggi Zurich
@anjor.rao thanks for sharing. I don't see the relation why Gin would break this so far as the error seems that
Backbone.Model
is not set and we don't use Backbone in Gin nor do we set any dependency on it. - π¨π¦Canada anjor.rao
@saschaeggi, I checked similar JS files in the Claro theme; however, there are no errors. Please confirm if this falls under the Gin project's scope, or should I raise this issue in Drupal Core?
- Status changed to Closed: cannot reproduce
11 months ago 8:51pm 23 May 2024 - π¨π΄Colombia tesla863 Chia
Hey
I had this problem and I was able to see a js error:
And the IMCE window broke:
I have generated a patch to use the optional chaining operator for the 'toolbarVariant' definition to avoid the error, and now the IMCE loads fine.
I hope this can help someone else.
- Status changed to Needs review
8 months ago 7:34pm 1 August 2024 - Status changed to Postponed: needs info
8 months ago 7:44pm 1 August 2024 - π¨πSwitzerland saschaeggi Zurich
As the toolbar looks pretty much broken in the screenshots, maybe it would be better to move this to IMCE to look into this?
- π¨π΄Colombia tesla863 Chia
Maybe. I'm not sure what should define
drupalSettings.gin.toolbar_variant
, and it fails when the IMCE window is opened. It even fails when accessing directly via/admin/imce/browser
. However, it could be a good idea to validate that it exists anyway to avoid breaking other scripts if it is not defined, this helped for my specific case:const toolbarVariant = drupalSettings?.gin?.toolbar_variant;
in /js/toolbar.js - Status changed to Needs review
8 months ago 9:46pm 12 August 2024 - π¨πSwitzerland saschaeggi Zurich
I've opened a MR, this needs a review π
- Status changed to Fixed
7 months ago 9:05am 29 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.