Add support for more plugins

Created on 6 November 2023, 11 months ago
Updated 7 November 2023, 11 months ago

Problem/Motivation

I'm really impressed with this approach of the fullcalendar integration and I have a big project coming up, where I'm going to use that very effectively. It's a hotel booking system with lots of rooms, and we need a calendar overview to see which rooms are occupied or available.

This could be done very nicely with the Timeline View. Yes, that requires a premium licence, but only for commercial offerings. So, to integrate and develop free solutions, it would even be free with their CC attribution.

Can extra plugins already be integrated into this module or do we have to develop integration for extra plugins first? If development is needed, I'd be happy to contribute to that.

What's your view on that and would you be willing to add that to the module?

Feature request
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

🇩🇪Germany jurgenhaas Gottmadingen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jurgenhaas
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update 11 months ago
    1 pass
  • @jurgenhaas opened merge request.
  • Status changed to Needs review 11 months ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    I've created a merge request which is working just fine, please have a look.

  • 🇦🇺Australia mingsong 🇦🇺

    There is a license limitation to a Drupal contribute module.

    Details see

    https://www.drupal.org/about/licensing#drupal-license

    I would recommend creating a custom module for your project for this purpose.

  • Status changed to Closed: won't fix 11 months ago
  • 🇦🇺Australia mingsong 🇦🇺
  • Status changed to Needs review 11 months ago
  • 🇩🇪Germany jurgenhaas Gottmadingen

    Please reconsider that. I'm very conscious about the licence and will do all I can, to never break that. In this case, the project and the code base will not contain any non-compliant code. It links to some external code which has a different licence, but that's not included in the code base. And that's allowed. Also, for non-commercial projects, the premium version of the fullcalendar library comes with a creative commons licence, see https://fullcalendar.io/docs/premium - and that's compatible with GPL with no issue at all.

  • 🇦🇺Australia mingsong 🇦🇺

    The Fullcalendar premium and plugins required is not under GPL-incompatible license.
    https://fullcalendar.io/license

    And also as Drupal license said

    Can Drupal projects include GPL-incompatible non-code assets? (e.g. fonts, icons, etc)

    Yes, so long as the maintainer has the right to distribute the non-code assets, they may be packaged and/or distributed "in aggregate" with GPL code. Only works that are derivative of the original work are subject to the GPL license.

    Quite frankly, I am not comfortable with that license.

    It is not difficult to develop a custom module for your project. If you want, you can even create a contribute module that provides the plugin you want working with this module.

    What you need to do, just two things.

    1. Using hook_library_info_alter hook to add the plugin library to the blocks.
    2. Using hook_form_BASE_FORM_ID_alter hook to add the additional plugin setting to the block configuration forms.
  • Status changed to Closed: won't fix 11 months ago
  • 🇦🇺Australia mingsong 🇦🇺
  • 🇩🇪Germany jurgenhaas Gottmadingen

    Sure, but we do NOT aggregate any code from fullcalendar.io into this module. Also, we do not distribute and code from fullcalendar.io.

    Instead, we get the website to load external assets from a different source. Nothing in GPL prevents us from doing that. The GPL licence is only concerned about the code you package with your module and that you distribute. None of that is being done here. And also, the premium licence of fullcalendar is Creative Commons, which is even more permissive than GPL and therefore fully compliant.

    It is not difficult to develop a custom module for your project.

    I know, but I wanted to add value to your module here, as other users will benefit from that work too. If you don't want me to add that value, that's OK, and totally your decision.

Production build 0.71.5 2024