Deprecated function: Creation of dynamic property is deprecated

Thanks for the bug report, and the patch. Here's some feedback:

1. +++ b/db_server/hosting_db_server.service.inc
   @@ -18,6 +18,8 @@ class hostingService_db_mysql extends hostingService_db {
   +  public $db_user;
   +  public $db_passwd;
   

   I wonder if it's worth defaulting these to empty strings, rather than NULLs?

2. +++ b/server/hosting_server.service.inc
   @@ -24,7 +24,9 @@ class hostingService {
   +  public $restart_cmd;
   

   I think this could/should be protected rather than public.

3. +++ b/server/hosting_server.service.inc
   @@ -24,7 +24,9 @@ class hostingService {
   +  public $port;
   

   I think this could/should be protected rather than public.

Mohd Sahzad → made their first commit to this issue’s fork.

The protected value in MR does not work:

mysite.com/node/25074/goto_site|https://mysite.com|1||Deprecated function: Creation of dynamic property hostingService_http_https_nginx::$https_enabled is deprecated in hostingService_https->load() (line 12 of /aegir/hosting_https/hosting_https.service.inc).
Mar 26 08:37:33 dev dev.cciplatform.com: mysite.com/node/25074/goto_site|https://mysite.com/hosting/c/dev1-ao.dev.cciplatform.com|1||Error: Cannot access protected property hostingService_http_https_nginx::$port in _hosting_site_url() (line 249 of /aegir/profiles/hostmaster/modules/aegir/hosting/site/hosting_site.module).

Updated by adding getPort method

added $https_enabled