Contrib.social

Remove dependency on Classy theme

Open on Drupal.org →
Created on 5 November 2023, about 1 year ago
Updated 6 November 2023, about 1 year ago

Creating a new issue per the Drupal10 deprecated code 📌 Change the code to avoid using functions, methods, constants, and services that have been deprecated in Drupal 9 and removed from Drupal 10 Needs review thread

The following files also have a dependency on classy theme, which is removed from Drupal10 core.

Most call {{ attach_library('classy/file') }}, but I haven't checked them all:

web/themes/contrib/coffee_zymphonies_theme/templates/field/file-link.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/content/node.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/content/search-result.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/content/comment.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/dataset/forums.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/navigation/book-navigation.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/content-edit/image-widget.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/content-edit/file-managed-file.html.twig
web/themes/contrib/coffee_zymphonies_theme/templates/misc/status-messages.html.twig

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

tonka67

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tonka67
  • First commit to issue fork.
  • @shiv_yadav opened merge request.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India shiv_yadav

    hello tonka67, i have remove dependency of classy theme. created MR.
    please review & retest it.
    Thanks.

  • Comment about 1 year ago →
    shweta__sharma

    Hi @shiv_yadav,
    The MR works fine the library is removed from the below-mentioned files - 

    templates/content-edit/file-managed-file.html.twig...
templates/content/comment.html.twig...
templates/content/node.html.twig...
templates/content/search-result.html.twig...
templates/dataset/forums.html.twig...
templates/field/file-link.html.twig...
templates/misc/status-messages.html.twig...

    Also from comment.html.twig file the condition should be removed too as there will be no action there.
    Thanks

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    shweta__sharma
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024