Issues reported by PHPStan

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$? ------ ---------------------------------------------------------------------- Line ldap_authentication/src/Controller/LoginValidatorBase.php ------ ---------------------------------------------------------------------- 546 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ------------------------------------------------------------------------------------ Line ldap_authorization/src/Plugin/authorization/Provider/LDAPAuthorizationProvider.php ------ ------------------------------------------------------------------------------------ 238 \Drupal calls should be avoided in classes, use dependency injection instead 246 \Drupal calls should be avoided in classes, use dependency injection instead 261 \Drupal calls should be avoided in classes, use dependency injection instead 278 \Drupal calls should be avoided in classes, use dependency injection instead 315 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------------ ------ --------------------------------------------------------------------- Line ldap_authorization/tests/src/Unit/LdapAuthorizationProviderTest.php ------ --------------------------------------------------------------------- 32 Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687 ------ --------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line ldap_query/src/Plugin/views/query/LdapQuery.php ------ ---------------------------------------------------------------------- 80 \Drupal calls should be avoided in classes, use dependency injection instead 87 \Drupal calls should be avoided in classes, use dependency injection instead 209 \Drupal calls should be avoided in classes, use dependency injection instead 344 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ -------------------------------------------------------- Line ldap_query/tests/src/Unit/ViewsSortTest.php ------ -------------------------------------------------------- 29 Call to deprecated method setMethodsExcept() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687 ------ -------------------------------------------------------- ------ ---------------------------------------------------------------------- Line ldap_servers/src/Form/ServerDeleteForm.php ------ ---------------------------------------------------------------------- 44 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line ldap_servers/src/Form/ServerEnableDisableForm.php ------ ---------------------------------------------------------------------- 72 \Drupal calls should be avoided in classes, use dependency injection instead 78 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line ldap_servers/src/ServerListBuilder.php ------ ---------------------------------------------------------------------- 88 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ -------------------------------------------------------- Line ldap_servers/tests/src/Unit/TokenTest.php ------ -------------------------------------------------------- 45 Call to deprecated method setMethods() of class PHPUnit\Framework\MockObject\MockBuilder: https://github.com/sebastianbergmann/phpunit/pull/3687 ------ -------------------------------------------------------- ------ ---------------------------------------------------------------------- Line ldap_user/src/Processor/DrupalUserProcessor.php ------ ---------------------------------------------------------------------- 250 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- ------ ---------------------------------------------------------------------- Line ldap_user/src/Processor/GroupUserUpdateProcessor.php ------ ---------------------------------------------------------------------- 206 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- [ERROR] Found 19 errors

Comments & Activities

Issue created by @bluegeek9
@bluegeek9 opened merge request.
Comment over 1 year ago →
System Message

bluegeek9 → committed 6d952819 on 8.x-4.x
Issue #3399148: Issues reported by PHPStan
Comment over 1 year ago →
🇺🇸United States bluegeek9
Issue was unassigned.
Comment over 1 year ago →
🇺🇸United States bluegeek9
@bluegeek9 opened merge request.
Comment over 1 year ago →
🇺🇸United States bluegeek9
Comment over 1 year ago →
System Message

bluegeek9 → committed c94ef88e on 8.x-4.x
Issue #3399148 by bluegeek9: Issues reported by PHPStan
Merge request !65Issue #3399148 by bluegeek9: Issues reported by PHPStan → (Merged) created by bluegeek9
Comment over 1 year ago →
System Message

bluegeek9 → committed dbd26c43 on 8.x-4.x
Issue #3399148 by bluegeek9: Issues reported by PHPStan
Merge request !66Resolve #3399148 "Setmethods" → (Merged) created by bluegeek9
Comment over 1 year ago →
System Message

bluegeek9 → committed 93b883c6 on 8.x-4.x
Issue #3399148 by bluegeek9: Issues reported by PHPStan
Status changed to Fixed over 1 year ago7:18pm 22 December 2023
Comment over 1 year ago →
🇺🇸United States bluegeek9
The last item needs to be replaced with a View. A view plugin is also needed for the status of the LDAP server.

------ ----------------------------------------------------------------------
Line ldap_servers/src/ServerListBuilder.php
------ ----------------------------------------------------------------------
88 \Drupal calls should be avoided in classes, use dependency injection
instead
------ ----------------------------------------------------------------------
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!66Issues reported by PHPStan
Merged

!65Issues reported by PHPStan
Merged

Comments & Activities

Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!66Issues reported by PHPStanMerged

!65Issues reported by PHPStanMerged

Comments & Activities

!66Issues reported by PHPStan
Merged

!65Issues reported by PHPStan
Merged