- Issue created by @loze
- last update
over 1 year ago 51 pass, 2 fail - @loze opened merge request.
- Status changed to Needs review
over 1 year ago 3:24am 1 November 2023 - πΊπΈUnited States loze Los Angeles
Test is failing because there is a test for checking if the name attribute is being removed.
Im not sure what the rationale behind removing them was. But it does not seem necessary an longer, at least not in my limited testing.
If the maintainers think this ok, I will remove them from the tests.
- Status changed to Needs work
over 1 year ago 3:45pm 1 November 2023 - πΊπΈUnited States eojthebrave Minneapolis, MN
I think this should be safe to do for all the fields on this form. My understanding is that this was done previously when the module used an older version of the RecurlyJS library where Drupal would need to create an
<input/>
field. In order to prevent the content of those fields from ever being sent to the server for PCI reasons the name attribute was removed. Effectively making them client-side only.RecurlyJS v4, which is what we use now, handles these fields differently. And this is no longer a concern.
- last update
over 1 year ago 53 pass - Status changed to Needs review
over 1 year ago 10:11pm 1 November 2023 - πΊπΈUnited States loze Los Angeles
Thanks for the clarification. I removed that check from the tests.
-
eojthebrave β
committed 8d526234 on 4.x authored by
loze β
Issue #3398236 by loze: Form values on recurlyJS payment form are always...
-
eojthebrave β
committed 8d526234 on 4.x authored by
loze β
-
eojthebrave β
committed cf8b2400 on 5.x authored by
loze β
Issue #3398236 by loze: Form values on recurlyJS payment form are always...
-
eojthebrave β
committed cf8b2400 on 5.x authored by
loze β
- Status changed to Fixed
over 1 year ago 12:35pm 2 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.