- Issue created by @BenStallings
- last update
about 1 year ago Composer require-dev failure - @benstallings opened merge request.
- Status changed to Needs review
about 1 year ago 9:51pm 31 October 2023 - last update
about 1 year ago Composer require-dev failure - last update
about 1 year ago 545 pass Quickly generate a patch file, from your repository. Since automated testing on the GitLab pipeline at the moment doesn't work correctly for Search API.
- Status changed to RTBC
about 1 year ago 7:33am 2 November 2023 The automated tests are passing and the sanity check works correctly. I think this can be merged. RTBC.
- ๐ฎ๐ณIndia Anmol singh Gurgaon ๐
Anmol singh โ made their first commit to this issueโs fork.
- last update
about 1 year ago Composer require-dev failure - Status changed to Fixed
about 1 year ago 4:21pm 11 November 2023 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks for reporting this problem!
We actually already guard against this a few lines further down, inopSimple()
, but apparently forgot it there. Or maybe it occurs even rarer inopBetween()
. Anyways, I think we should just use the same fix we used there:($this->value['type'] ?? '') == 'offset'
.(I also donโt quite understand why we donโt just set
$base_timestamp
regardless, but probably out of scope here.)Anyways, merged a simplified version of the MR. Thanks again, everyone!
-
drunken monkey โ
committed a094dd61 on 8.x-1.x
Issue #3398192 by drunken monkey, BenStallings, admirlju: Fixed warning...
-
drunken monkey โ
committed a094dd61 on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.