Make oEmbed thumbnail dimensions more permissive

Created on 31 October 2023, over 1 year ago

When an oEmbed provider returns a thumbnailWidth and/or thumbnailWidth that is NULL, setThumbnailDimensions() throws an error, since it requires the width and height to be integers that are larger than 0. This is a similar issue as #3071682: The oembed Resource value object should be more permissive for NULL dimensions → .

- Create a media bundle that supports e.g., Infogram (I ran into this issue using this provider). To do so, create a provider bucket with Infogram enabled using the https://www.drupal.org/project/oembed_providers → module.
- Add a media entity at /media/add. Choose the newly added media bundle. Use e.g., https://infogram.com/live-calgary-election-oct-7-1gl8m37ex6y7p36 as oEmbed URL.

Write/refactor existing test.

None.

\Drupal\media\OEmbed\Resource::setThumbnailDimensions accepts argument that are either int or null, instead of only int values.

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

Media →

Last updated 33 minutes ago

Created by

🇨🇦Canada brunodbo

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @brunodbo
Status changed to Needs work over 1 year ago7:40pm 31 October 2023
Comment over 1 year ago →
🇨🇦Canada brunodbo
First attempt at a patch. Leaving as "Needs work" for test.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 5.3 & MySQL 5.5
last update over 1 year ago
Composer error. Unable to continue.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 5.3 & MySQL 5.5
last update over 1 year ago
Composer error. Unable to continue.
Comment 2 months ago →
🇦🇺Australia imclean Tasmania
Bunny.net's oembed response doesn't return thumbnail dimensions so resulted in an error when trying to add a video. After applying the changes in the patch manually the oembed resource was accepted.

One related problem is that Bunny.net returns a thumbnail URL, which means it should also return the thumbnail dimensions according to the oEmbed specs, but it doesn't.

Production build 0.71.5 2024