Contrib.social

ConfigEntityType inherited functions return FALSE instead of NULL

Open on Drupal.org →
Created on 31 October 2023, almost 2 years ago
Updated 19 January 2024, almost 2 years ago

Problem/Motivation

In ConfigEntityType.php:

  /**
   * {@inheritdoc}
   */
  public function getBaseTable() {
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  public function getRevisionDataTable() {
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  public function getRevisionTable() {
    return FALSE;
  }

  /**
   * {@inheritdoc}
   */
  public function getDataTable() {
    return FALSE;
  }

Whereas in EntityTypeInterface, each function says:

   * @return string|null
   *   The name of the entity type's revision table, or NULL if none exists.

Proposed resolution

Return NULL instead, or update the phpdoc comments.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Fixed

Version

11.0 🔥

Component
Entity  →

Last updated 21 days ago

Created by

solideogloria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024