Fix the errors of phpstan (1) (Cloud)

Issue created by @xiaohua guan
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
@xiaohua-guan opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Status changed to Needs review over 1 year ago1:02am 2 November 2023
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
@yas

Please take a look. Thanks.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Status changed to Needs work over 1 year ago6:38am 2 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the great patch. I found phpcs complains like what I commented in our own GitLab CI. Can you please check the ones? Thanks
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Status changed to Needs review over 1 year ago8:05am 2 November 2023
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
Status changed to Needs work over 1 year ago8:36am 2 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the update. I ran the phpcs in our own GitLab CI, then it was successful. So please rebase the patch before we merge it. Thanks!
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Status changed to Needs review over 1 year ago9:31am 2 November 2023
Comment over 1 year ago →
🇯🇵Japan xiaohua guan Tokyo, Japan
@yas

I rebased the code. Please take a look again. Thanks.
Status changed to RTBC over 1 year ago5:49am 3 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@xiaohua-guan

Thank you for the update. I ran the BDD tests and they have been passed successfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Composer require failure
Comment over 1 year ago →
System Message

yas → committed b58de1fa on 6.x authored by Xiaohua Guan →
Issue #3398036 by Xiaohua Guan, yas: Fix the errors of phpstan (1) (...
Comment over 1 year ago →
System Message

yas → committed d253abe3 on 5.x authored by Xiaohua Guan →
Issue #3398036 by Xiaohua Guan, yas: Fix the errors of phpstan (1) (...
Status changed to Fixed over 1 year ago5:56am 3 November 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the errors of phpstan (1) (Cloud)

Problem/Motivation

Comments & Activities