- Issue created by @keshav patel
- š®š³India keshav patel
The provided patch file "fix_coding_standards-3398035-2.patch", fixes all the
phpcs
reported issues. - Status changed to Needs review
about 1 year ago 12:23pm 31 October 2023 - Status changed to RTBC
about 1 year ago 6:23am 2 November 2023 - šµšPhilippines clarkssquared
Hi Keshav,
I applied your patch #2 and I confirmed that it fixes all the PHPCS issues, the only remaining issues being flagged are "project", "datestamp", and "version" which I believe appears when the module is installed via composer.
ā entity_autocomplete_suggestions git:(master) ā curl https://www.drupal.org/files/issues/2023-10-31/fix_coding_standards-3398035-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2103 100 2103 0 0 3723 0 --:--:-- --:--:-- --:--:-- 3775 patching file 'src/Controller/EntityAutocompleteSuggestionsController.php' patching file 'src/EntityAutocompleteSuggestionsMatcher.php' patching file 'src/Form/AutocompleteSuggestionsConfigForm.php' ā entity_autocomplete_suggestions git:(master) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_autocomplete_suggestions FILE: ...b/entity_autocomplete_suggestions/entity_autocomplete_suggestions.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- Time: 311ms; Memory: 10MB ā contrib git:(master) ā