- Issue created by @bluegeek9
- last update
about 1 year ago 37 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:41pm 30 October 2023 - πΊπΈUnited States bluegeek9
The 92 character line is part of the entity annotation. I am not sure why it is listed.
I am not sure how I should handle the two InvalidPrefix. We could move the functions to message_digest.module. Or, we could rename the functions and use a hook_update_N to update the fields. I prefer the first option as it does not require a hook_update_N; there is less chance of something going wrong.
$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source FILE: ...stom/message_digest-3397844/src/Entity/MessageDigestInterval.php ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 37 | WARNING | Line exceeds 80 characters; contains 92 | | characters (Drupal.Files.LineLength.TooLong) ---------------------------------------------------------------------- FILE: ...essage_digest-3397844/message_digest_ui/message_digest_ui.module ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 16 | ERROR | All functions defined in a module file must be prefixed | | with the module's name, found | | "message_digest_allowed_values_callback" but expected | | "message_digest_ui_message_digest_allowed_values_callback" | | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix) 36 | ERROR | All functions defined in a module file must be prefixed | | with the module's name, found | | "message_digest_default_value_callback" but expected | | "message_digest_ui_message_digest_default_value_callback" | | (Drupal.NamingConventions.ValidFunctionName.InvalidPrefix) ----------------------------------------------------------------------
-
bluegeek9 β
committed e66ede66 on 8.x-1.x
Issue #3397844: Issues found by phpcs
-
bluegeek9 β
committed e66ede66 on 8.x-1.x
- Status changed to Downport
3 months ago 8:28pm 17 September 2024 - Status changed to Fixed
3 months ago 8:29pm 17 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.