Show target folder on export/import page, to clarify where the file(s) will be exported to

Created on 30 October 2023, about 1 year ago
Updated 2 November 2023, about 1 year ago

Problem/Motivation

To help new users get up to speed faster, we could show the target/source folder in the help text at the bottom of the import/export tabs. This way, the user can immediately see that the default target folder is ../config/menu_migration, and adjust if necessary.

Steps to reproduce

Install the module, and not know where the exported file(s) will end up, or where they will be attempted to be imported from.

Proposed resolution

Show the target/source folders at the bottom in the help text at the bottom of the import/export tabs.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇩🇰Denmark ressa Copenhagen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ressa
  • @ressa opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • 🇩🇰Denmark ressa Copenhagen

    I updated the default target path, and also updated the README to align more with the template .

  • Status changed to Closed: works as designed about 1 year ago
  • 🇷🇴Romania bbu23

    Hi ressa,

    Thank you for reporting this, but I won't be accepting the change as it is intentional to have the folder set to config instead of sites/default/files for various reasons:
    1. We don't want the exported menu links to be exported in a public folder.
    2. The developer should do the minimum effort of choosing the right folder (if the config one is not good enough)
    3. The sites/default/files is not tracked by git and the purpose is to have it tracked.
    4. The module is implemented in a way that the main folder accepts exports per subsite, so having sites/default/files as the default target would break the sites structure, and the purpose of the module for multisites.

    The changes in the README file are welcomed, but you'd have to create a separate issue for that, since the MR contains two mixed issues.

  • Status changed to Needs review about 1 year ago
  • 🇩🇰Denmark ressa Copenhagen

    Hey @bbu23: Thanks for a fast review, I really appreciate it.

    I do get your points. However, as I see it -- any developer would immediately change to use a folder outside Drupal's root. I only made this proposal, to make it easier for site builders to immediately use the module. And they may not all use Git ...

    But your point #4 is in itself enough to keep as it is, if changing target path would stop the module from working.

    I have updated the Issue Summary and Merge Request to show the target folder on the import and export page, and updated the README.

  • Status changed to Needs work about 1 year ago
  • 🇷🇴Romania bbu23

    Please see my comment in the MR.

  • Status changed to Needs review about 1 year ago
  • 🇩🇰Denmark ressa Copenhagen
    • bbu23 committed 0f2f07a9 on 2.0.x authored by ressa
      Issue #3397627: Show target folder on export/import page, to clarify...
  • Status changed to Fixed about 1 year ago
  • 🇷🇴Romania bbu23

    Thank you for your contribution.

  • 🇩🇰Denmark ressa Copenhagen

    You're welcome, and thank you for creating and maintaining a great module.

    Perhaps you could consider advancing to Beta, or even RC in the next 2.x release? Because it seems to me that the module is very stable, works as expected, and with no open bug reports.

    The reason I suggest this, is that I tried other menu export/import modules with stable releases, which does not work ... and for some people, Alpha might sound buggy and unstable, which this module is not at all.

  • 🇷🇴Romania bbu23

    Thanks. Sure, I am aware of that and I do have the intention to advance it, that's for sure. The module is not yet complete, but when it will be ready, there will be a stable release.

  • 🇩🇰Denmark ressa Copenhagen

    Sounds good, have a nice day.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024