- Issue created by @ressa
- @ressa opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:48am 30 October 2023 - 🇩🇰Denmark ressa Copenhagen
I updated the default target path, and also updated the README to align more with the template → .
- Status changed to Closed: works as designed
about 1 year ago 3:47pm 30 October 2023 - 🇷🇴Romania bbu23
Hi ressa,
Thank you for reporting this, but I won't be accepting the change as it is intentional to have the folder set to config instead of sites/default/files for various reasons:
1. We don't want the exported menu links to be exported in a public folder.
2. The developer should do the minimum effort of choosing the right folder (if the config one is not good enough)
3. The sites/default/files is not tracked by git and the purpose is to have it tracked.
4. The module is implemented in a way that the main folder accepts exports per subsite, so having sites/default/files as the default target would break the sites structure, and the purpose of the module for multisites.The changes in the README file are welcomed, but you'd have to create a separate issue for that, since the MR contains two mixed issues.
- Status changed to Needs review
about 1 year ago 5:24pm 30 October 2023 - 🇩🇰Denmark ressa Copenhagen
Hey @bbu23: Thanks for a fast review, I really appreciate it.
I do get your points. However, as I see it -- any developer would immediately change to use a folder outside Drupal's root. I only made this proposal, to make it easier for site builders to immediately use the module. And they may not all use Git ...
But your point #4 is in itself enough to keep as it is, if changing target path would stop the module from working.
I have updated the Issue Summary and Merge Request to show the target folder on the import and export page, and updated the README.
- Status changed to Needs work
about 1 year ago 7:57pm 30 October 2023 - Status changed to Needs review
about 1 year ago 9:28am 31 October 2023 - Status changed to Fixed
about 1 year ago 7:36pm 31 October 2023 - 🇩🇰Denmark ressa Copenhagen
You're welcome, and thank you for creating and maintaining a great module.
Perhaps you could consider advancing to Beta, or even RC in the next 2.x release? Because it seems to me that the module is very stable, works as expected, and with no open bug reports.
The reason I suggest this, is that I tried other menu export/import modules with stable releases, which does not work ... and for some people, Alpha might sound buggy and unstable, which this module is not at all.
- 🇷🇴Romania bbu23
Thanks. Sure, I am aware of that and I do have the intention to advance it, that's for sure. The module is not yet complete, but when it will be ready, there will be a stable release.
Automatically closed - issue fixed for 2 weeks with no activity.