Compatibility with drupal 10

Created on 30 October 2023, 8 months ago
Updated 14 November 2023, 8 months ago

I simply added ^10 in the core_version_requirement (In commerce_chronopost.info.yml) in order for it to work on drupal-10 as well.

πŸ’¬ Support request
Status

Fixed

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @MartinPJB
  • Status changed to Needs work 8 months ago
  • πŸ‡«πŸ‡·France solene_ggd

    Thanks for your patch, please use double pipes to add D10 compatibility in core_version_requirement instead of single pipe.
    Moreover, I see an entity query created in commerce_chronopost_cron() that needs an accessCheck() to be D10 compatible.
    Please fix your patch.

  • I apologize for not noticing I forgot a pipe in the core_version_requirement line. Here is a fix to this patch adding a pipe, and also an

    ->accessCheck()
    

    in the commerce_chronopost_cron() function available in commerce_chronopost.module.

  • Status changed to Needs review 8 months ago
  • @nicolasgraph opened merge request.
  • Status changed to Fixed 8 months ago
Production build 0.69.0 2024