Contrib.social

Compatibility with drupal 10

Open on Drupal.org →
Created on 30 October 2023, 8 months ago
Updated 14 November 2023, 8 months ago

I simply added ^10 in the core_version_requirement (In commerce_dhl_express.info.yml) in order for it to work on drupal-10 as well.

💬 Support request
Status

Fixed

Version

1.0

Component

Code

Created by

MartinPJB

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @MartinPJB
  • Status changed to Needs work 8 months ago
  • Comment 8 months ago →
    🇫🇷France solene_ggd

    Thanks for your patch.
    I still see an entity query created in commerce_dhl_express_cron() that needs an accessCheck() to be D10 compatible.
    Moreover, there are some calls of the deprecated hook hook_field_widget_WIDGET_TYPE_form_alter that was removed in Drupal 10. See https://www.drupal.org/node/3180429 → .
    Please fix your patch.

  • Comment 8 months ago →
    MartinPJB

    No worries. I fixed my patch and added the 

    ->accessCheck()

    you were asking. I also switched hook_field_widget_WIDGET_TYPE_form_alter() to hook_field_widget_single_element_WIDGET_TYPE_form_alter (Thanks to your link → ). Tell me if there is still stuff that needs to be worked on.

  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    MartinPJB
  • @nicolasgraph opened merge request.
  • Status changed to Fixed 8 months ago
  • Comment 8 months ago →
    🇫🇷France solene_ggd
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024