Fix items found by PHPStan

Created on 27 October 2023, 8 months ago

Updated 3 November 2023, 8 months ago

Problem/Motivation

PHPStan was added to the default CI workflow. It found a few items.

Steps to reproduce

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ -------------------------------------------------------------------------------------- 
  Line   authorization_drupal_roles/src/Plugin/authorization/Consumer/DrupalRolesConsumer.php  
 ------ -------------------------------------------------------------------------------------- 
  72     Unsafe usage of new static().                                                         
         💡 See:                                                                               
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static          
 ------ -------------------------------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Form/AuthorizationProfileForm.php                                         
 ------ ------------------------------------------------------------------------------ 
  81     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/ConfigurableAuthorizationPluginBase.php                            
 ------ ------------------------------------------------------------------------------ 
  48     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 [ERROR] Found 3 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States bluegeek9

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @bluegeek9
Assigned to shalini_jha
Comment 8 months ago →
🇮🇳India shalini_jha
@shalini_jha opened merge request.
Issue was unassigned.
Status changed to Needs review 8 months ago5:30am 2 November 2023
Comment 8 months ago →
🇮🇳India shalini_jha
Hi @bluegeek9
I have fixed all the mentioned issues and added a MR , please review
Thanks
Comment 8 months ago →
System Message

bluegeek9 → committed 87d0fbfc on 8.x-1.x authored by shalini_jha →
Issue #3397327 by shalini_jha: Fix items found by PHPStan
Status changed to Fixed 8 months ago2:28pm 3 November 2023
Comment 8 months ago →
🇺🇸United States bluegeek9
I think the constructor for src/Plugin/ConfigurableAuthorizationPluginBase.php should be removed and the StringTranslationTrait added. This will be covered in another issue.
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024