- Issue created by @kevinn
- Assigned to mohd sahzad
- Status changed to Needs review
about 1 year ago 9:46am 27 October 2023 - Open in Jenkins → Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7 (--ignore-platform-reqs)last update
about 1 year ago 79 pass - Issue was unassigned.
- Open in Jenkins → Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7 (--ignore-platform-reqs)last update
about 1 year ago 79 pass -
AaronBauman →
committed f4feecc4 on 5.0.x authored by
kevinn →
Issue #3397134 by kevinn: Creation of dynamic property time
-
AaronBauman →
committed f4feecc4 on 5.0.x authored by
kevinn →
- 🇺🇸United States AaronBauman Philadelphia
Committed, thanks for the patch.
I'm went with #3, which has a better comment.{@inheritdoc}
is not appropriate here: the parent does not define this property, there is nothing to inherit.Also, a point of issue queue etiquette @Mohd Sahzad:
Give someone more than a minute to post a patch when they open a new issue before you assign it to yourself. If someone else has already posted a patch, there's no good reason to post a 2nd patch which does the same thing. If you do post a followup patch, make sure you're specifying the reasons for doing so in your comment. - 🇺🇸United States DamienMcKenna NH, USA
Is there anything still needed on this or can it be closed?
- Status changed to Fixed
about 1 year ago 8:26pm 14 November 2023 - 🇺🇸United States AaronBauman Philadelphia
should have been marked "fixed"
while i have your attention though, i'll cross-post a big MR in 🐛 Creation of dynamic property $key Needs review which attempts to address the many many other dynamic properties.
Automatically closed - issue fixed for 2 weeks with no activity.