- Issue created by @primsi
- Status changed to Needs review
over 1 year ago 2:47pm 26 October 2023 - 🇸🇮Slovenia primsi
Initial patch.
We can set Framework name and Framework version via methods:
GatherContentClientInterface::setFrameworkName('Drupal'); GatherContentClientInterface::setFrameworkVersion(\Drupal::VERSION);
But it seems like the integration version needs to be a constant
GatherContentClientInterface::INTEGRATION_VERSION
The proposed patch results in this user agent:
user-agent: "Integration-Drupal-10.1.4/6.1.0"
- last update
over 1 year ago 5 pass - 🇨🇭Switzerland berdir Switzerland
We extend the class, so we can just override getVersionString() or getIntegrationVersion()?
The requested string was Integration-Drupal-/Drupal Plugin Version
We actually have 3 version numbers, the drupal version, the module version, and the version of the comonent (the constant). I will ask for confirmation if we should include all 3 version numbers and in which format.
- 🇸🇮Slovenia primsi
Yes, we could also just extend that method. Would make even more sense if including all 3 is needed.
- last update
over 1 year ago 5 pass - 🇸🇮Slovenia primsi
As per discussion, overriding the method. If the version is not available, then do we output something like `user-agent: "Integration-Drupal-10.1.4/dev"` (current patch) or core version?
- last update
over 1 year ago 5 pass - Status changed to Fixed
over 1 year ago 7:13am 9 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.