- Issue created by @primsi
- Status changed to Needs review
over 1 year ago 12:20pm 26 October 2023 - 🇭🇺Hungary mxr576 Hungary
Just by reading the issue summary, I am unsure if this change is needed
DSN which fails in \Symfony\Component\Mailer\Transport\Dsn::fromString with InvalidArgumentException.
InvalidArgumentException is an unchecked exception, it is meant to stop execution to protect the system, IOW cause WSOD.
https://phpstan.org/blog/bring-your-exceptions-under-control
-
zengenuity →
committed 96c6c99e on 1.0.x authored by
Primsi →
Issue #3396902 by Primsi: SymfonyMailer::mail should handle other...
-
zengenuity →
committed 96c6c99e on 1.0.x authored by
Primsi →
- Status changed to Fixed
over 1 year ago 3:51pm 2 December 2023 - 🇺🇸United States zengenuity
@Primsi, thanks for the patch. Committed.
@mxr576, I take your point about the exception stopping execution, but I think in this case, that's already happening, since we're at the very end of the mailing process, and we're returning FALSE to tell the rest of Drupal that it failed. I don't see any harm in triggering Drupal to display a nicely-formatted error message rather than crashing with a WSOD.
Automatically closed - issue fixed for 2 weeks with no activity.