- Issue created by @danielspeicher
- @danielspeicher opened merge request.
- Assigned to jurgenhaas
- 🇩🇪Germany danielspeicher Steisslingen
There are a few points left:
- Missing cache backend declaration for performance.
Drupal\drd\Drush\Generators\ActionPlugin
extends theBaseGenerator
class. There are undefined function calls.- In,
src/Entity/Account
there are constants accessed in DRD Agent, which do not exist anymore. - The new ECA Event implementation must be used.
The summary can be found here: https://git.drupalcode.org/project/drd/-/pipelines/42048/codequality_report
- Status changed to Needs work
about 1 year ago 1:17pm 31 October 2023 - First commit to issue fork.
- 🇩🇪Germany jurgenhaas Gottmadingen
Fixed all issues except ECA 2.0 compatibility. That will follow next.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:22am 1 November 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
This is now completed and can be reviewed and merged.
- 🇩🇪Germany danielspeicher Steisslingen
This is strange, there is still an error in the pipeline which I can not reproduce locally:
------ --------------------------------------------- Line src/UpdateProcessor.php ------ --------------------------------------------- 483 No error to ignore is reported on line 483. ------ --------------------------------------------- [ERROR] Found 1 error
- Status changed to RTBC
about 1 year ago 11:58am 1 November 2023 -
jurgenhaas →
committed 7dbdf7b8 on 4.1.x authored by
danielspeicher →
Issue #3396848 by danielspeicher, jurgenhaas: Coding Standards for PHP...
-
jurgenhaas →
committed 7dbdf7b8 on 4.1.x authored by
danielspeicher →
- Status changed to Fixed
about 1 year ago 12:10pm 1 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.