- Issue created by @eiriksm
- Assigned to Shreya_98
- Assigned to eiriksm
- 🇳🇴Norway eiriksm Norway
Please don't take over the issue @Shreya_th, at least not yet. I have all of this locally now, including tests
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:15am 26 October 2023 - 🇳🇴Norway eiriksm Norway
Pipeline containing the failure (demonstrating the bug): https://git.drupalcode.org/issue/media_fotoweb-3396820/-/jobs/228055
The MR pipeline should contain the fix and a test that is passing. - 🇩🇪Germany szeidler Berlin
Thanks for spotting the issue. Yes, the `local_image` property actually should be removed.
There seems to be still some uses for the
local_image
property on the media thumbnail. That seems to be needed to be refactored/removed as well. https://git.drupalcode.org/project/media_fotoweb/-/blob/2.0.x/src/Plugin...Unfortunately my testing is currently limited, since I have no customer which grants me local access to their Fotoweb installation and Fotoweb so far didn't wanted to provide me a demo/sandbox access to be able to properly independent work with their API and selection widget…
- 🇳🇴Norway eiriksm Norway
I see. Well, I updated the MR with the couple other instances of usage of the old config name, so please feel free to do as you please with that then :)
- Status changed to RTBC
6 months ago 3:48pm 15 May 2024 - 🇩🇪Germany szeidler Berlin
Using the MR on a project for quite a while. Seems to behave as it should. Thanks for the contribution @eiriksm
-
szeidler →
committed 10e37e4c on 2.0.x authored by
eiriksm →
Issue #3396820 by eiriksm: Wrong (probably old) array key used for...
-
szeidler →
committed 10e37e4c on 2.0.x authored by
eiriksm →
- Status changed to Fixed
6 months ago 3:49pm 15 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.