adsense-8.x-1.4 release

Created on 25 October 2023, 8 months ago
Updated 6 May 2024, about 2 months ago

Question1: is adsense-8.x-1.4-rc1 stable enough to be used in a Drupal 10 website?
Question2: will there be an adsense-8.x-1.4 release and when is it expected?

πŸ’¬ Support request
Status

Closed: cannot reproduce

Component

Miscellaneous

Created by

πŸ‡§πŸ‡ͺBelgium vhelmont

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @vhelmont
  • πŸ‡ΊπŸ‡ΈUnited States bas123

    I can only tell you that it is not compatible with Drupal 10!

    I thought I had uninstalled it from a Drupal 9 site and went forward and updated my site to Drupal 10 and now it is crashed on the front end, meaning no content will display and many of the Administration pages as well are displaying the following error:

    Drupal\Component\Plugin\Exception\PluginNotFoundException: The "filter_adsense" plugin does not exist. Valid plugin IDs for Drupal\filter\FilterPluginManager are: editor_file_reference, entity_embed, filter_caption, filter_autop, filter_null, filter_html, filter_html_escape, filter_image_lazy_load, filter_url, filter_html_image_secure, filter_align, filter_htmlcorrector, media_embed in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

    And I have unable to restore the site or re-enable the Adsense module!

    Also, it may be that other (non Drupal 10 ready) modules that update.php required I remove may also cause this error state once the Adsense issue is resolved, but that remains to be seen!

    I am open to any response that might help me resolve this issue because I have multiple Adsense Ad positions that may or may not be affected as well. In short, I do not know whether or not my Production site, which is dependent upon the Adsense Ads will even work in Drupal 10 without this module.

  • πŸ‡΅πŸ‡ΉPortugal jcnventura

    The code for filter_adsense is there (https://git.drupalcode.org/project/adsense/-/blob/8.x-1.x/src/Plugin/Fil...) in the current version.. The reason the site is breaking is due to the configuration of your text format including the adsense filter. Unfortunately, the module neither adds nor removes the filters on install/uninstall, so the same way that the filter was manually added, it needs to be manually removed.

    You can probably fix that by exporting the configuration and then searching for filter_adsense, and removing that line from the text formats, and then re-importing configuration. Or add adsense back to the system, and run drush en adsense to re-enable the module.

  • πŸ‡§πŸ‡ͺBelgium vhelmont

    Hello,

    In my local drupal 10 site:

    • I installed adsense using composer
    • $ composer require 'drupal/adsense:^1.4@RC'

    • I enabled the module by:
    • Clicking Administration : Extend and searching the Adsense block.
      I checked AdSense
      I checked AdSence ads.txt
      I unchecked AdSense pre-2007 code
      I clicked Install at the bottom of the page.

    • I configured it via Administration : Configuration : Web services : AdSense
    • Under the Settings tab
      I inserted my Site Google AdSense Publisher ID.
      I unchecked the Display anti ad-block request? box.
      I temporary checked the Enable test mode? box
      I unchecked the Disable Google AdSense ads? box.
      I checked the Placeholder when ads are disabled? Box.
      The Placeholder text to display message field contains:
      Google AdSense
      Under the Managed Ads I kept the defaults
      Under Custom Search I kept the defaults
      I clicked the Save configuration button.

    • Position the ADS in a block.
    • Structure : Block layout
      The Olivero theme must be active
      Search the block where the ADS must be displayed:
      Sidebar
      Click the Place block button of the Sidebar block
      Click the Place block button of the Managed ad block

    • In the configued block page:
    • I inserted an Ad ID
      I kept the other defaults
      I clicked Save block

    In my case a adsense place holder is shown in the sidebar.
    The status report shows no errors.
    As far as I can test, the administration pages keep working.

    Regards,
    Albert

  • πŸ‡ΊπŸ‡ΈUnited States bas123

    @jcnventura β†’ ,

    You can probably fix that by exporting the configuration and then searching for filter_adsense, and removing that line from the text formats, and then re-importing configuration. Or add adsense back to the system, and run drush en adsense to re-enable the module.

    I searched my site via Control Panel search and in three instances of my site: "Production" (Drupal 9.5.11), "Development 1" (Drupal 9.511), "Development 2" (Drupal 10.1.6) which is crashed in the front tend and parts of Admin, "filter_adsense" does not show up anywhere.

    Also, on the Development 2 site, I do not have access to CKEditor5 configuration for Full HTML (same Adsense errors) which would be the likely candidate for locating any references to "Adsense Filters", and when I view in Development 1, where I do have access to Full HTML, I do not see any references there anyway.

    I installed your version via composer require 'drupal/adsense:^1.4@RC' and confirmed through the info.yml that the module reflects Drupal ^10 compatibility.

    However, when I try installing the three modules:

    • AdSense
    • AdSense ads.txt
    • AdSense pre-2007 code

    I cannot install:

    Unable to install AdSense, adsense.settings already exists in active configuration.

    Prior to taking steps to become Drupal 10 ready, with all three installations, I had multiple blocks with "raw html codes" (Not CKEditor), for Google Adsense IFrame Codes, and do not recall using the Adsense modules other than the one that holds my Google Adsense Account number. (AdSense ads.txt ???)

    I have the option of working with the two development sites online (No local capabilities) and have tried multiple methods of reversing the problem before utilizing a surefire methods on Production.

    To be honest, I do not see how this module is of any use and am happy to remove it unless someone can demonstrate its value.

    Either way, it seems to be the biggest stumbling block to moving into Drupal 10.

    Any thoughts are appreciated.

  • πŸ‡¦πŸ‡ΊAustralia larowlan πŸ‡¦πŸ‡ΊπŸ.au GMT+10

    Error message
    Unable to install AdSense, adsense.settings already exists in active configuration.

    This sounds like your configuration is corrupted.

    If the module is uninstalled, its configuration should not exist.

    Do you have access to drush? I think you will need to do some deletion of adsense config via drush, followed by enabling adsense modules, followed by removing the adsense filters from your input formats, followed by uninstalling the module.

  • Status changed to Closed: cannot reproduce about 2 months ago
Production build 0.69.0 2024