Test against current core minor (10.1), previous (10.0) and next (10.2)

Created on 25 October 2023, 8 months ago
Updated 7 November 2023, 7 months ago

Problem/Motivation

πŸ› Ckeditor 5 Interface not loading on text formats using entity embed Active raised confusion around the fact that the CKEditor 5 support that was added in ✨ Drupal 10 & CKEditor 5 readiness Fixed works only on Drupal >=10, and not also on Drupal 9.5.

(The tests specifically are skipped on <10: https://git.drupalcode.org/project/entity_embed/-/blame/ac6f2fe13b18f5f55c43badd6f46195776e2351c/tests/src/FunctionalJavascript/CKEditor5IntegrationTest.php#L71-73)

But … it was actually only ever tested against Drupal 10.1 πŸ˜… Combined with the fact that Drupal core minors update CKEditor 5 to new major versions, and based on past experience we know that sometimes a CKEditor 5 major release in a new Drupal core minor results in contrib modules needing to re-build their JS and tag a new release, that is then compatible only with that minor.

Steps to reproduce

N/A

Proposed resolution

  1. βœ… β€” already the case in HEAD
  2. Automatically run tests on the previous minor (10.0) β€” this would ensure we know whether we need distinct releases
  3. Automatically run tests on the next minor (10.2) β€” this would ensure we know about upcoming need for a new release of Entity Embed for that core branch

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

CKEditor integration

Created by

πŸ‡§πŸ‡ͺBelgium Wim Leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024