- Issue created by @wim leers
- @wim-leers opened merge request.
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 10:57am 25 October 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Results:
- β Failed on
10.0.x
(which uses CKEditor 5 v35.4.0): https://git.drupalcode.org/project/entity_embed/-/jobs/222870 - β
Passed on
10.1.x
(which uses CKEditor 5 v38.0.1 in 10.0.0 and v38.1.0 in 10.1.0 β and v39.0.1 in 10.1.3 β : https://git.drupalcode.org/project/entity_embed/-/jobs/222854 - β
Passed on
10.2.x
(which uses CKEditor 5 v39, and soon v40 β see π [upstream] Update CKEditor 5 to 40.0.0 Needs review ): https://git.drupalcode.org/project/entity_embed/-/jobs/222855
This that this actually would be a pretty strong reason to:
2.0.x
of Entity Embed for Drupal 10.0.x, but recompile for10.0.x
2.1.x
for Drupal 10.1.x (straight branch from8.x-1.x
)8.x-1.x
of Entity Embed for Drupal 9.5.x (revert β¨ Drupal 10 & CKEditor 5 readiness Fixed )- in the future,
2.2.x
for Drupal 10.2.x or 10.3.x or β¦
@Dave Reid, I briefly mentioned the above last Friday, but I'm not sure you fully realized this. I suspect you won't like this π But unfortunately it's out of my hands β it's a policy thing on the CKEditor 5 side.
They are working on doing fewer breaking changes β which is why they didn't go from https://github.com/ckeditor/ckeditor5/releases/tag/v38.0.0 directly to https://github.com/ckeditor/ckeditor5/releases/tag/v39.0.0, but did https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0 and tried doing https://github.com/ckeditor/ckeditor5/releases/tag/v38.2.0-alpha.1, but eventually never tagged a 38.2.0, and instead had to go to https://github.com/ckeditor/ckeditor5/releases/tag/v39.0.0.
But they have still got some ways on maturing into avoiding breaking changes.
- β Failed on
- Assigned to dave reid
- Status changed to Needs review
about 1 year ago 11:16am 25 October 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I just wrote "2.0.x for Drupal 10.0.x", but I think it's equally reasonable for Entity Embed to require Drupal 10.1.x, and just say that that is the first and only version to support CKEditor 5.
P.S.: the self-RTBC here is only for the added test jobs. But still, it's failing on
10.0.x
, so really β¦ this need discussion with @Dave Reid to determine how he wants to proceed here. - πΊπΈUnited States dave reid Nebraska USA
Dave Reid β made their first commit to this issueβs fork.
- πΊπΈUnited States dave reid Nebraska USA
I think I've got it covered by skipping the CKEditor5 test on 10.0, using the new GitLab CI variables for OPT_IN_TEST_PREVIOUS_MAJOR, OPT_IN_TEST_PREVIOUS_MINOR, and OPT_IN_TEST_NEXT_MINOR.
- πΊπΈUnited States dave reid Nebraska USA
Everything is passing now. Merging.
-
Dave Reid β
committed f52be693 on 8.x-1.x authored by
Wim Leers β
Issue #3396568 by Wim Leers, Dave Reid: Updated GitLab CI workflow with...
-
Dave Reid β
committed f52be693 on 8.x-1.x authored by
Wim Leers β
- Status changed to Fixed
about 1 year ago 8:24pm 6 November 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π Looking good! π
Automatically closed - issue fixed for 2 weeks with no activity.