Use the new PermissionChecker service

Please review the patch. Thanks

Thanks for working on this!

+++ b/src/Form/NodeAuthlinkNodeForm.php
@@ -182,7 +182,7 @@ class NodeAuthlinkNodeForm extends FormBase {
-      if (isset($enable[$node_instance->bundle()]) && $enable[$node_instance->bundle()] && ($account->hasPermission('create and delete node authlinks') || $account->hasPermission(sprintf('create and delete node %s authlinks', $node_instance->bundle())))) {

I think we should use dependency injector, so the permission checker service should be injected in the form class.

See https://www.drupal.org/docs/drupal-apis/services-and-dependency-injectio... →

Yes. @tunic you are correct. I will work on this

@tunic Checked in D11 core modules and it still uses $account->hasPermission in many places.

As per this https://www.drupal.org/node/3348054 → , Its introduced in 10.2.0. I checked in D11 core modules and it uses $account->hasPermission in many places instead of DI. Not sure how to accomplish this.

Eg: core/modules/book/book.module , core/modules/content_translation/content_translation.module etc..

Yes, this new service is pretty new, there's a lot of places to update. It is not something really needed here, but I thought it was a nice novice task.

When you say "Not sure how to accomplish this" you mean injecting the service in the form class? You have to edit the create and __construct methods of the class NodeAuthlinkNodeForm. See for example how the entity_type.manager service is injected.

Working on this.