mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated

+      if ($path_alias != null) {
+        $path_alias = mb_strtolower($alias_manager->getAliasByPath($path));
+      }

As per Drupal coding standards, it is NULL, not null. Furthermore, instead of comparing the value directly with NULL, it is better to use empty() or is_null().

Gautam_105@ → made their first commit to this issue’s fork.

@apaderno ,
i have fixed this issue and created MR for the same. Please review this MR

@apaderno,
i have udated my MR review my changes.

This module is relying on the API of the path_alias module which says AliasManagerInterface::getAliasByPath() returns string. If you are getting a NULL then I would suggest you find out why and fix that. What you are suggesting is that module A can not rely on the published API of module B but is required to type check every value returned from a method in module B?

I wanted to add that I'm seeing this problem with version 2.0.6 as well. The patch does not apply on that version but that's not unexpected.

The documentation for AliasManagerInterface::getAliasByPath() is pretty clear on what that method returns: An alias that represents the path, or path if no alias was found.

Either the class implementing AliasManagerInterface returns the wrong value, or it returns NULL because that is the parameter the method gets.

AliasManager::getAliasByPath() returns the correct value, though.