- Open in Jenkins โ Open on Drupal.org โCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7 updated depslast update
8 months ago 1 pass - Status changed to Needs work
8 months ago 7:51am 25 October 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ if ($path_alias != null) { + $path_alias = mb_strtolower($alias_manager->getAliasByPath($path)); + }
As per Drupal coding standards, it is
NULL
, notnull
. Furthermore, instead of comparing the value directly withNULL
, it is better to useempty()
oris_null()
. - ๐ฎ๐ณIndia Gautam_105@
Gautam_105@ โ made their first commit to this issueโs fork.
- Open in Jenkins โ Open on Drupal.org โCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7 updated depslast update
8 months ago 1 pass - @gautam_105 opened merge request.
- Status changed to Needs review
8 months ago 8:05am 25 October 2023 - ๐ฎ๐ณIndia Gautam_105@
@apaderno ,
i have fixed this issue and created MR for the same. Please review this MR - Status changed to Needs work
8 months ago 8:19am 25 October 2023 - Issue was unassigned.
- Open in Jenkins โ Open on Drupal.org โCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7 updated depslast update
8 months ago 1 pass - Status changed to Needs review
8 months ago 11:37am 25 October 2023 - ๐ฎ๐ณIndia Gautam_105@
@apaderno,
i have udated my MR review my changes. - Status changed to Active
4 months ago 9:12pm 6 March 2024 - ๐บ๐ธUnited States solotandem
This module is relying on the API of the path_alias module which says
AliasManagerInterface::getAliasByPath()
returns string. If you are getting a NULL then I would suggest you find out why and fix that. What you are suggesting is that module A can not rely on the published API of module B but is required to type check every value returned from a method in module B?