- Issue created by @karlshea
- Status changed to Needs review
about 1 year ago 10:37pm 23 October 2023 - last update
about 1 year ago 18 pass - πΊπΈUnited States karlshea Minneapolis πΊπΈ
Well the Gitlab integration is broken so ignore the issue fork.
Patch attached.
- Status changed to Needs work
about 1 year ago 3:16pm 24 October 2023 - πΊπΈUnited States TomTech
Hi @KarlShea,
Thanks for the report for this particular configuration.
As noted in the read me (and also should be reported in the license dashboard), guest checkout is not supported currently.
Configure (or create) a checkout flow at admin/commerce/config/checkout-flows
This flow must set "Guest checkout: Not allowed" for the "Login or continue
as guest" pane.More work would need to be done to support this, including:
1. Determining what would happen if "Create a new account for an anonymous order" is NOT enabled? (Maybe we allow guest checkout ONLY if this is enabled?)
2. Updating the dashboard to reflect this change.
3. Updating the read me to reflect this change.
4. Determine if there are any other issues that prevented this from being supported previously. (It might be that there aren't any other items to address, other than that listed here + the submitted patch.) - πΊπΈUnited States karlshea Minneapolis πΊπΈ
I saw the related issue so I thought maybe the dashboard/readme just hadn't been updated, but it seems that wasn't the case!
Determining what would happen if "Create a new account for an anonymous order" is NOT enabled? (Maybe we allow guest checkout ONLY if this is enabled?)
I believe it would function the same as it does without the patch, where the license is created but doesn't have a valid user assigned (since
onPaid
/onPlace
aren't doing any checks either before creating the license.I'll update the patch with changes to the dashboard/readme.
Determine if there are any other issues that prevented this from being supported previously. (It might be that there aren't any other items to address, other than that listed here + the submitted patch.)
I'm testing this with commerce_file and everything seems to work well!
- last update
about 1 year ago 18 pass - @karlshea opened merge request.
- last update
about 1 year ago 18 pass - Status changed to Needs review
about 1 year ago 4:39pm 24 October 2023 - last update
about 1 year ago 18 pass - πΊπΈUnited States karlshea Minneapolis πΊπΈ
I created a product variation type that assigns a role and it also worked with guest checkout.
- π©π°Denmark ramlev
Cannot see why we can enable the feature to support anonymous shopping with commerce_license. Every order have an email attached.
And for my usecase, i want to enable it for anonymous users, and add a token so it's possible pΓ₯ to send an email with the license code. Even though that the user cannot login to it's account.
Make sense ?