- Issue created by @scott_euser
- last update
about 1 year ago 36 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:33pm 23 October 2023 - First commit to issue fork.
- last update
11 months ago 36 pass - Status changed to Needs work
11 months ago 9:16pm 22 December 2023 - heddn Nicaragua
Tests run differently on legacy test bots and gitlab. We'll need to fix that before we can merge this.
- First commit to issue fork.
- last update
11 months ago 36 pass - last update
11 months ago 36 pass - First commit to issue fork.
- last update
11 months ago 36 pass - last update
11 months ago 30 pass, 1 fail - last update
11 months ago 30 pass, 1 fail - last update
11 months ago 30 pass, 1 fail - last update
11 months ago 30 pass, 1 fail - last update
11 months ago 36 pass - 🇮🇪Ireland lostcarpark
The tests were mostly failing on the [error], [warning] and [notice] labels, which seem to have color coding codes in the output. I simply took those labels out of the checks, and left to match on the rest of the output.
There were also someassertStringNotContainsString
checks against "4", that were failing. I'm guessing that was matching against something in the color coding. I expanded those checks to check the output does not contain "Processed 4 items" - last update
11 months ago 36 pass - last update
11 months ago 36 pass - 🇮🇪Ireland lostcarpark
I've added variables to the .gitlab-ci.yml to enable additional tests:
- MAX_PHP (tests against PHP 8.3)
- PREVIOUS_MAJOR (tests against D9)
- PREVIOUS_MINOR (currently tests against 10.0)
- NEXT_MINOR (currently tests against 10.2)
- NEXT_MAJOR (tests against D11)
Currently NEXT_MAJOR is failing, but as it is only considered a warning, I suggest leaving it in. Since the .info.yml file for the module contains
core_version_requirement: '>=9.1'
, it makes sense to test against the D11 and fix issues it discovers. If I can figure out the reason before this gets merged, I'll try to fix. If not, I suggest opening a separate issue for D11 compatibility.I'd also suggest not trying to fix code quality issues under this issue, but instead open separate issues after this merges.
- Status changed to Needs review
11 months ago 11:21pm 26 December 2023 - last update
11 months ago 36 pass - 🇮🇪Ireland lostcarpark
It turns out that specifying:
core_version_requirement: '>=9.1'
Is not a good idea when using
OPT_IN_TEST_NEXT_MAJOR
.It runs the following:
grep -q "\^11" *.info.yml || (grep -q "\^10" *.info.yml && sed -i "s/\^10/\^10 \|\| ^11/" *.info.yml)
This checks if ^11 is in the .info.yml file. If it isn't, it will attempt to replace ^10 with ^11. If neither succeeds, it aborts the NEXT_MAJOR test.
I've updated the .info.yml file to:
core_version_requirement: '^9.1 || ^10 || ^11'
All tests are now passing.
There are still code quality issues, but I suggest looking at those in separate issues.
- last update
11 months ago 30 pass, 1 fail - last update
11 months ago 36 pass - last update
11 months ago 30 pass, 1 fail - last update
11 months ago 36 pass - 🇮🇪Ireland lostcarpark
I have put back the [notice] and [warning] tags in the error checks using regular expressions to skip any color codes. Also combined some of the "1/4" type checks into the same regular expressions.
- last update
11 months ago 36 pass - Status changed to RTBC
11 months ago 2:32pm 27 December 2023 - heddn Nicaragua
Thank you for your effort to get this over the finish line. Much appreciated.
- last update
11 months ago 36 pass -
heddn →
committed 0485cb8c on 6.0.x authored by
scott_euser →
Issue #3396130 by lostcarpark, scott_euser, heddn: Switch GitLab CI...
-
heddn →
committed 0485cb8c on 6.0.x authored by
scott_euser →
- Status changed to Fixed
11 months ago 2:34pm 27 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.