Create a new NodeRepository for the code from Drupal\node\NodeStorage

Open on Drupal.org →

Created on 23 October 2023, over 1 year ago

Problem/Motivation

The database driver for MongoDB needs to override the class Drupal\Core\Entity\Sql\SqlContentEntityStorage. MongoDB does document/JSON storage instead of relational database storage.
The Node entity is overriding that class in Drupal\node\NodeStorage. The problem for the database driver for MongoDB is that it then also needs to override the methods in Drupal\node\NodeStorage. It also needs to duplicate the code inside Drupal\file\FileStorage too. Duplicating code is wrong.
Another problem is that the code in Drupal\node\NodeStorage class is that it is NOT extending the functionality from the class Drupal\Core\Entity\Sql\SqlContentEntityStorage. The extra code can easily being moved to another class.

Proposed resolution

- Create a new Drupal\node\NodeRepository class/service and move the code/methods from Drupal\node\NodeStorage to the new class/service.
- Deprecate the methods and the class Drupal\node\NodeStorage.

Remaining tasks

User interface changes

None

API changes

- New service node_repository with the methods revisionIds(), userRevisionIds(), countDefaultLanguageRevisions(), updateType() and clearRevisionsLanguage().
- The methods revisionIds(), userRevisionIds(), countDefaultLanguageRevisions(), updateType() and clearRevisionsLanguage() in the class Drupal\node\NodeStorage are deprecated.
- The class Drupal\node\NodeStorage is deprecated.

Data model changes

None

Release notes snippet

None

📌 Task

Status

Active

Version

11.0 🔥

Component

Node system →

Last updated about 15 hours ago

No maintainer

Created by

🇳🇱Netherlands daffie

Live updates comments and jobs are added and updated live.

mongodb

Sign in to follow issues

Comments & Activities

Issue created by @daffie
Comment 9 days ago →
🇦🇺Australia acbramley
Definitely agree with this one! I never knew NodeStorage only implemented its own special functions.

There are 2 functions that I'd get rid of (deprecate first of course) entirely:
- ::countDefaultLanguageRevisions - this isn't used anywhere in the core codebase
- ::updateType - this function is just scary, see 📌 Deprecate NodeStorage::updateType and remove type change handling in NodeType::postSave Active

As for the remaining:
- ::revisionIds is used in a handful of tests and in NodeRevisionDeleteForm
- ::userRevisionIds is used in a handful of hooks inside NodeHooks and NodeHooks1 (these classes will change in 📌 Remove NodeHooks1 Active
- ::clearRevisionsLanguage is used by a single hook in NodeHooks1::configurableLanguageDelete
Comment 9 days ago →
🇦🇺Australia acbramley
Comment 9 days ago →
🇦🇺Australia acbramley
Postponed on 📌 Deprecate NodeStorage::updateType and remove type change handling in NodeType::postSave Active
Comment 8 days ago →
🇦🇺Australia acbramley

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024