- Issue created by @pdureau
-
pdureau →
committed d6cd8ddb on 2.0.x authored by
Christian.wiedemann →
Issue #3395953 by Christian.wiedemann: [2.0.x] Add new Form Builder
-
pdureau →
committed d6cd8ddb on 2.0.x authored by
Christian.wiedemann →
- Status changed to Needs work
about 1 year ago 9:04am 23 October 2023 - 🇫🇷France pdureau Paris
Form implementation too heavy
The form implementation was done using UI elements from paragraphs module, as it was initially discussed, but we underestimated the hevainess of the paragraphs source code.
Now 20 % of the project PHP code is found in /src/form/
Also, addition of:
- ui_patterns.module
- templates/
- css/
- icons/
- js/
- src/Element/DropdownAction
- src/Element/UiPatternsOperations
The current state of specifications is taking inspiration from Image Styles admin pages and Manage Display admin pages. It may be lighter because using Drupal Core native form elements.
Update of the slots & props forms when variant is changes
This is an undocumented behaviour. I know we want to make the condition mechanism addable in UI Patterns Settings 3.x, but is there a simpler way ? Also, if we change variants, do we keep our props settings?
Context management
How to add context to Source plugins was documented and tessted. But it still not clear how to set the conetxt from the consumer plugins (layout, field formatters...).
Maybe it is not implemented yet in the form builder:
protected function getComponentSourceContexts(): array { return []; }
Failed tests
I don't know if the issue is on the "consumer" side or the form builder side:
Layout plugin:
- variant is not saved
- Issues with Layout Builder: "add blocks" not in the regions, & blcok not configurable. I guess we need to add some stuff from ui_patterns_layout_builder
Block plugin:
- "RuntimeException: The subform and parent form must contain the #parents property, which must be an array." maybe because we are using buildComponentsForm() from blockForm() instead of buildConfigurationForm()
View style plugin
- Call to undefined method Drupal\Core\Form\FormState::getCompleteFormState() in ComponentStyle->buildOptionsForm(). Do I need to use ComponentSettingsFormBuilderTrait instead?
FieldFormatters:
- Don't work on layout builder
- Some sources (example: menu and breadcrumb for links) show up in layout builder but not in manage display
alterComponent
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - @christianwiedemann opened merge request.
-
Christian.wiedemann →
committed 2a6e00e8 on 2.0.x
Resolve #3395953 "2.0.x add new"
-
Christian.wiedemann →
committed 2a6e00e8 on 2.0.x
- 🇫🇷France pdureau Paris
"Form implementation too heavy" will be done in 📌 [2.0.0-alpha1] Form builder: Simpler sources selector Active
- 🇫🇷France pdureau Paris
"alterComponent" was already done in the ComponentElementBuilder
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Merge request !55Issue #3311480 by pdureau, Grimreaper, DuaelFr: Reduce preprocess hooks usage... → (Open) created by Christian.wiedemann
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Not currently mergeable. - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Fixed
10 months ago 7:12pm 9 February 2024 - 🇫🇷France pdureau Paris
Merged. Future tasks will be done in dedicated issues.
-
Christian.wiedemann →
committed 1f49eae2 on 2.0.x
ISSUE-#3395953: Fix blocks saving
-
Christian.wiedemann →
committed 1f49eae2 on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.