Contrib.social

fieldset was removed arbitrarily with no issue number reference in commit fdf69a53094 , restore expected markup

Open on Drupal.org →
Created on 19 October 2023, 8 months ago
Updated 23 October 2023, 8 months ago

Problem/Motivation

Affects those upgrading from <= 1.40 to >=1.41

This commit July 5th 2022 has no issue number reference, no justification for the removal of the fieldset.

commit fdf69a5309415e86a0f74f58c9ba1627b313a1a8
Author: itamair <itamair@1179076.no-reply.drupal.org>
Date:   Tue Jul 5 01:30:55 2022 +0200

    General enhancements to GeofieldProximityFilter:
    - better stylng and label expositions in case of exposed operator;
    - Value/Disyance, Min, Max and Origin labels made protected/overridable properties of the class;
    - etc.

Our exposed filter is missing markup that we expected in Drupal 9, now we've updated geofield for D10 compatibility reasons but our form markup was unexpected, the css didn't apply correctly so restoring this with a patch.

I was unable to find any issue in the queue that discussed the removal of the fieldset element. So I am restoring it in this issue.

Steps to reproduce

Upgrade from 1.34 to the latest 1.55

notice markup missing for fieldsets on exposed filters.

Proposed resolution

See patch

Remaining tasks

Please commit the patch and tag a new release after committing the fix.

User interface changes

Restore expected fieldset element

API changes

Minor

Data model changes

None

🐛 Bug report
Status

Fixed

Version

1.55

Component

Code

Created by

🇨🇦Canada joseph.olstad

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024