- Issue created by @Harlor
- Merge request !8Issue #3395327: Init auth and transmission for new localize.drupal.org β (Merged) created by Harlor
- π©πͺGermany Harlor Berlin
The Draft MR currently contains changes that allow to push translations to the new REST endpoints of l10n_server ( https://www.drupal.org/project/l10n_server/issues/3395508 π New endpoints for l10n_client_contributor Needs review ).
The new concept for the authentication as described in https://www.drupal.org/project/l10n_client/issues/3395488 π Localize client authentication with d.o infrastructure Active still needs to be implemented.
azhardotcoder β changed the visibility of the branch 3395327-replace-xmlrpc-for to hidden.
azhardotcoder β changed the visibility of the branch 3395327-replace-xmlrpc-for to active.
- Status changed to Needs review
3 months ago 1:33pm 22 August 2024 Integrated server-side submission logic
L10nClientContributorHelper.php:
- Integrated additional handling to better manage translation submissions, including improved error management using \Exception.
l10n_client_contributor.module:
- Removed redundant lines to streamline the l10n_client_contributor_save_translation function and enhance code clarity.
- TranslationForm.php:
- Added logic to send translations to the server with a response validation. This includes error handling that displays a message if the contribution fails, or a success message if it succeeds.
- Implemented a hidden button to trigger form rebuilding when a render cache is active, ensuring all strings are collected from the page.
- Improved comments and documentation for better code readability and maintenance.
- Issue was unassigned.
-
Harlor β
committed 13f8aa72 on 3.x
Issue #3395327: Remove obsolete xmlrpc related stuff form translation...
-
Harlor β
committed 13f8aa72 on 3.x
-
Harlor β
committed 5a1032a1 on 3.x
Issue #3395327: Cleanup post request handling
-
Harlor β
committed 5a1032a1 on 3.x
-
Harlor β
committed d941cd35 on 3.x
Issue #3395327: Init auth and transmission for new localize.drupal.org
-
Harlor β
committed d941cd35 on 3.x
- Status changed to Needs work
3 months ago 4:02pm 23 August 2024 - π«π·France fmb PerpinyΓ , Catalonia, EU
We still need to:
- Clean up the code. I guess most of the code in l10n_client_contributor.module is obsolete (talking about you, l10n_client_contributor_send_translation()).
- Figure out how to deal with authentication ( π Localize client authentication with d.o infrastructure Active ).
- π©πͺGermany donquixote
The commits from this MR made it into the 3.x branch in a bad way, bypassing the pipeline tests.
It seems the following happened:
- The 3.x branch was merged into the issue MR branch.
- The 3.x branch was rebased or reset to the tip of the issue MR branch.
- More minor changes were pushed to the MR branch.
- The minor changes were then squash-merged into the 3.x branch, resulting in https://git.drupalcode.org/project/l10n_client/-/commit/ff75bc814e058add...Since this we have failing tests.
I think the correct way is to hard-reset the 3.x branch to before this issue, which is 3.0.0-alpha3.
I don't remember if drupalcode.org allows us to hard reset a branch (that is, force push). - π©πͺGermany donquixote
It seems the following happened:
- The 3.x branch was merged into the issue MR branch.
- The 3.x branch was rebased or reset to the tip of the issue MR branch.Actually more likely it was just merged with fast-forward.
- π«π·France fmb PerpinyΓ , Catalonia, EU
Even as a maintainer, I cannot use "git push --force" on a branch which is used for a dev release.
Mainly, the culprit is this commit which caused a conflict in l10n_contributor.module which was not correctly dealt with, introducing again the l10n_client_contributor_send_translation() function which had been previously removed in a previous commit (for good reason, as it is now implemented in a service, plus it used xmlrpc). Some things need to be removed (like old xmlrpc-based tests) but this commit cannot be held as responsible.
I think this can now be closed, since the rest of the work (authentication) will be dealt with in π Localize client authentication with d.o infrastructure Active .