- Issue created by @Harlor
- Status changed to Needs review
about 1 year ago 1:12pm 20 October 2023 - Status changed to Needs work
about 1 year ago 9:40am 27 October 2023 - 🇫🇷France fmb Perpinyà, Catalonia, EU
Thanks for your contribution @Harlor! While I've never dealt with REST endpoints myself, I added some minor comments, some of them less minor, such as permission issues.
Once we are done with this, ideally you should enable the module on the platform on gitlab.com and open an MR there for core.extension.yml.
Just so I can get a general idea for the Localize project, do you have an idea of how much work is left, and what time you might be able to dedicate in a month? In your opinion, how many developers should be working on this?
(P. S.: I still have your charger, I'll need your email address to finalize shipping.)
- First commit to issue fork.
azhardotcoder → changed the visibility of the branch revert-917a89be to hidden.
azhardotcoder → changed the visibility of the branch l10n_server-3395508-3395508-contributor-endpoints to hidden.
azhardotcoder → changed the visibility of the branch 3.0.x to hidden.
- Status changed to Needs review
3 months ago 8:46pm 22 August 2024 - Remove Unused JSON:API Resource Configurations and Adjust Dependencies
- Deleted obsolete JSON:API resource configuration files:
jsonapi_extras.jsonapi_resource_config.l10n_server_string.yml
jsonapi_extras.jsonapi_resource_config.l10n_server_translation.yml
jsonapi_extras.settings.yml
- Removed unnecessary dependency on
jsonapi_extras
module.
- Status changed to Needs work
3 months ago 1:50pm 23 August 2024 - 🇫🇷France fmb Perpinyà, Catalonia, EU
Thanks! Next steps:
- Figuring out why we need the L10nRemoteSubscriber event subscriber for, and either remove debug traces or remove it completely.
- Properly check access in L10nServerContributorResource::access(): user should be a member of the translation team. That being said, we most certainly should implement access checks properly in 🐛 Translation suggestion creation and moderation don't provide group permission Active instead.
- Deal with authentication ( 📌 Localize client authentication with d.o infrastructure Active ), instead of the temporary basic auth mechanism.
- 🇪🇸Spain guiu.rocafort.ferrer Barcelona
guiu.rocafort.ferrer → made their first commit to this issue’s fork.
- Merge request !67Draft: Resolve #3395508 "Contributor endpoints cherrypick" → (Open) created by guiu.rocafort.ferrer