Add option to ban indifenitely (sort of)

Initial patch.

+++ b/auto_unban.module
@@ -82,3 +90,24 @@ function auto_unban_form_ban_ip_form_alter(array &$form, FormStateInterface $for
+    $time = \Drupal::time();
+    // Ban for as much as the db field allows us.
+    $ip_manager->setBanDurationOverride(2147483647 - $time->getCurrentTime());
+    $ip_manager->banIp($ip);

I think if we go with a separate submit button then a new method that's banIpIndefinitely() or banIpWithExpire() makes more sense, we don't need to introduce state in the storage then.

Thanks. Seems it's fine even with just a new argument (that's what the module is doing anyway with $attempts).

Few notes for the maintainer:

1. +++ b/auto_unban.module
   @@ -1,5 +1,6 @@
   +use Drupal\auto_unban\BanIpManager as AutoUnbanBanIpManager;
   

   I aliased this for a bit better code clarity, because the replacement class auto_unban provides has the same name as the one that it substitutes.

2. +++ b/auto_unban.module
   @@ -15,7 +24,7 @@ function auto_unban_form_ban_ip_form_alter(array &$form, FormStateInterface $for
   +      'data' => t('Ban count'),
   

   We discussed with @Berdir, that just Count is a bit confusing. So we are proposing here a small renaming. Sorry for the scope creep.

Have tested this and selecting add indefinatly does ban the IP address with a date set to 2038 (max unix time stamp).

Committed, I wasn't initially a fan of this, but as an option it's certainly valuable.

Automatically closed - issue fixed for 2 weeks with no activity.