- Issue created by @jnettik
- Status changed to Needs review
about 1 year ago 9:27pm 25 October 2023 - π¦π·Argentina tguerineau
Hi,
I've looked into the issue described and have made the following changes:
1- Updated
prototype_prepare_menu_items
Function: Modified the function to add adata-plugin-id
attribute for each menu item based on the menu link's plugin ID.2- JavaScript Updates: Changed the way IDs are retrieved in the JavaScript. Instead of transforming the text of the menu item, we now read the
data-plugin-id
attribute.3- Typo Fix: Corrected the typo in the JavaScript where "pannel" was misspelled. It's now correctly spelled as "panel".
I've attached the patch that includes these changes. I'd appreciate any feedback or testing on this. Please let me know if there are additional adjustments needed!
- Assigned to jldust
- Status changed to RTBC
about 1 year ago 1:32pm 1 November 2023 - πΊπΈUnited States jldust
Thanks for catching this and creating a patch, I've opened a MR that will be included in the next tagged release.
- @jldust opened merge request.
-
jldust β
committed 18202490 on 5.x
Issue #3395030 by tguerineau: Dropdown menu IDs shouldn't be based on...
-
jldust β
committed 18202490 on 5.x
-
jldust β
committed 18202490 on 5.0.x
Issue #3395030 by tguerineau: Dropdown menu IDs shouldn't be based on...
-
jldust β
committed 18202490 on 5.0.x
-
jldust β
committed 18202490 on 5.1.2.x
Issue #3395030 by tguerineau: Dropdown menu IDs shouldn't be based on...
-
jldust β
committed 18202490 on 5.1.2.x
- Status changed to Fixed
about 1 year ago 6:38pm 1 November 2023