- Issue created by @ravi kant
- 🇮🇳India mahtab_alam
I have tried installing the amp theme with drupal 9.5.8 with additional module and site runs well.
- Status changed to RTBC
12 months ago 5:01am 26 December 2023 - Status changed to Active
12 months ago 10:17am 8 January 2024 - 🇬🇧United Kingdom rachel_norfolk UK
So far as I can see, there are no changes proposed to test here? Are you suggesting it "works as designed", @mahtab_alam?
If there is nothing to test, we can't have reviewed a test.
- 🇬🇧United Kingdom rachel_norfolk UK
Testing this on 10.2 leads to a dependency error on the stable theme. That's because it was deprecated at end of 9.x
- Status changed to Closed: works as designed
12 months ago 10:32am 8 January 2024 - 🇬🇧United Kingdom rachel_norfolk UK
Using Drupal 9.5.11 as the base core, adding amp module and installing is successful.
I think that the amp theme needs a little work to make it compatible.
I'd suggest:
- Adding a dependency for the amp module into the amp theme composer.json
- Removing the requirement on the now deprecated stable theme.
Closing as Works as Designed.
- 🇮🇳India ravi kant Jaipur
I am still getting same error. Attaching screenshot.
Getting below error when i am enabling and setting default to sub theme ExAMPle Subtheme 8.x-3.1
- 🇬🇧United Kingdom rachel_norfolk UK
That error is coming from BigPipe as it is incompatible with AMP theme. There was an attempt to resolve this at https://www.drupal.org/project/amp/issues/2723627 → but it appears that there might be further composer.json changes required to ensure it is not running.
Disabling bigpipe makes the error go away, that’s for sure.
- 🇮🇳India ravi kant Jaipur
Thank you @ravi kant
Errors is not appearing after disable bigpipe modue.