- Issue created by @jedgar1mx
- πΊπΈUnited States jedgar1mx Detroit
Looks like the issue is with the key - item loops. They were split into a `for` and `if` statements which cause some weird behaviors. Probably caused by some linting tool since this affected all twig templates.
- πΊπΈUnited States jedgar1mx Detroit
I think this was caused by trying to automate Drupal 10 fixes for deprecated twig templates on for loops. I updated the patch to match the new syntax.
- Assigned to Rajab Natshah
- Status changed to Needs review
about 1 year ago 8:14pm 17 October 2023 - π―π΄Jordan Rajab Natshah Jordan
Thank you, Edgar, for reporting and patching.
Testing, and will have a commit and quick fix release for this issue.
-
Rajab Natshah β
committed 101dceb3 on 9.0.x authored by
jedgar1mx β
Issue #3394665 by jedgar1mx: Fix Broken and deprecated twig templates on...
-
Rajab Natshah β
committed 101dceb3 on 9.0.x authored by
jedgar1mx β
-
Rajab Natshah β
committed c4dbbac5 on 10.0.x authored by
jedgar1mx β
Issue #3394665 by jedgar1mx: Fix Broken and deprecated twig templates on...
-
Rajab Natshah β
committed c4dbbac5 on 10.0.x authored by
jedgar1mx β
- Status changed to Active
about 1 year ago 4:50pm 22 October 2023 -
Rajab Natshah β
committed cca5908a on 10.0.x
Revert Issue #3394665: Fix Broken and deprecated twig templates on for...
-
Rajab Natshah β
committed cca5908a on 10.0.x
-
Rajab Natshah β
committed d1ced43a on 9.0.x
Issue #3394665: Limit the 9.0.x branch to ~9.5.0 only
-
Rajab Natshah β
committed d1ced43a on 9.0.x
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 5:28pm 22 October 2023 - π―π΄Jordan Rajab Natshah Jordan
β Released varbase_bootstrap_paragraphs-9.0.16 β
- π―π΄Jordan Rajab Natshah Jordan
- Fixed by a revert for broken and deprecated twig templates on for loops
- Limited the
9.0.x
branch to Drupal~9.0
only - β Release varbase_bootstrap_paragraphs-9.0.16 β
- π Revamp the 9.1.x branch for Varbase Bootstrap Paragraphs to work with Drupal ~10.1.0 and custom needed changes for a smoother upgrade process Fixed
- β Release varbase_bootstrap_paragraphs-9.1.0 β
- π©πͺGermany stefan.korn Jossgrund
I suppose patch from #4 should have been used as the base for the change, but instead patch from #3 was used.
The bottom line is that there was conditional filtering in the for loop which has been deprecated with Twig 3. Patch from #3 removed the conditional filtering and moved the if condition in the for loop, but this breaks the bootstrap because loop.first is not correct then. Instead with patch from #4 the conditional filtering is Twig 3 (and Twig 2.10) compatible as it uses twig filter.
So the current state of the module is:
9.0 is back to old conditional filtering with if in the for loop, which is only Twig 2 compatible
9.1 and 10 are not using conditional filtering anymore (putting the if inside the for loop) and thus breaking the functionality. So for 9.1 and 10 this should be changed to use the TWIG filter instead as proposed with patch from #4.
- π―π΄Jordan Rajab Natshah Jordan
Fixed the logic again with more testing in
π Fix null returns for Background colors with columns in Twig ~3 FixedThen
β Released varbase_bootstrap_paragraphs-9.0.17 β
β Released varbase_bootstrap_paragraphs-9.1.1 β
β Released varbase_bootstrap_paragraphs-10.0.0-rc2 β - π©πͺGermany stefan.korn Jossgrund
Hm, at least for carousel this does not work as expected I suppose:
https://git.drupalcode.org/project/varbase_bootstrap_paragraphs/-/blob/9...
loop.first is not reached, therefore no item is active initially and the carousel does not show.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
12 months ago 7:41pm 9 December 2023