Add services/container features from upstream Symfony Mailer component

Created on 17 October 2023, 9 months ago
Updated 21 October 2023, 8 months ago

Problem/Motivation

As discussed and proposed by AdamPS in ✨ Add Symfony Messenger support for async messsages (emails as queues) Active . The desire is to break out services into a dedicated issue.

The base branch is intended to be a new 2.x requiring Drupal 10.1 as a minimum. D10.1 has convenient autowiring capabilites for this feature. Fortunately we can make it minimum because it will be the minimum Drupal version in about a month. I assume the 1.x version will be supported temporarily.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Nil

API changes

Data model changes

Nil

πŸ› Bug report
Status

Closed: duplicate

Version

1.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @dpi
  • Status changed to Needs review 9 months ago
  • πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

    There is code for above but for some reason I cannot create a MR from it.

  • Status changed to Closed: duplicate 8 months ago
  • πŸ‡¬πŸ‡§United Kingdom AdamPS

    Thanks.

    1. The part about auto-wiring we definitely want and it should be applied to all services. There is an existing issue πŸ“Œ Consider marking some classes/functions @internal and find more convenient ways of dependency injection Active , and I put a link there to your code.
    2. Everything relating to transports is going into core in πŸ“Œ [PP-1] Add symfony mailer transports to DIC Postponed . If that misses D10.2 then we would need to copy it into the Mailer Transport module (not here).
    3. The Connections and StateTransport classes are more related to ✨ Add Symfony Messenger support for async messsages (emails as queues) Active which I don't think we need in this module, but it we do let's handle in the other issue.

    >> The desire is to break out services into a dedicated issue.
    When I said that I meant the first item above, and I meant to use the existing issue - sorry if that wasn't clear. Probably we don't really need this issue.

  • πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

    Alright, I assume you're carrying the code forward?

    The scope is both not entirely clear to me and likely more effort than I wish to take on. Though I'm happy to coordinate on Messenger (and Mailer-service) related enhancements.

Production build 0.69.0 2024