Contrib.social

From email ajax requests prevents entering a value easily

Open on Drupal.org →
Created on 17 October 2023, about 1 year ago
Updated 29 May 2024, 6 months ago

Problem/Motivation

The "To email" textfield, when "Custom To email address" is selected, is doing an ajax call after every letter (on keyup maybe) which makes it difficult to enter any email address.

I imagine this is checking for commas in the "From email". If there are any commas, it means there are multiple "from" email addresses which means you that a "From name" can't be used.

Steps to reproduce

  • Go to "Settings" tab
  • Go to "Emails / Handlers" tab
  • Add a new email handler
  • Under "Send from", first click "From name" and choose "Custom from name". Add a value for the Custom from name
  • Now set From email to "Custom From email address"
  • Add a value for the email

This is probably not much of an issue on the add screen. I just suggested that as the easiest way to replicate. This is most likely going to pop up when the user is changing from [site:mail] to a "Custom From email address" and there is already a "From name" set.

Proposed resolution

I haven't looked into the code yet, I only have a few thoughts off the top of my head.

  1. Maybe a different ajax trigger might help, on blur or something.
  2. Maybe this is a validation that needs to happen on submit.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

6.2

Component

Code

Created by

🇺🇸United States asherry

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024