1) On a site that uses many scripts, the lists of source values becomes long, which makes it hard to mange the items.
2) Storing all values of one type of source (e.g. script-src) on a single line, makes it very sensitive for merge conflicts in the configuration file seckit.settings.yml when developing/testing multiple features that need to allow another source of scripts. Fixing such merge conflicts is hard and mistakes are easily made.
Use text areas with multiple rows to make it more manageable
Place every item on a separated line in the text area
Store the source items as an array (sequence) of strings (multiple lines in the seckit.settings.yml config file), so different changes to the same csp source can be merged automatically by source control.
Textareas instead of texfields for the sources.
sequences instead of strings for the source configuration items.
Needs review
2.0
Code
The last submitted patch, 6: 3394615-store-csp-sources-on-mulitiple-lines-6.patch, failed testing.
View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.