- Issue created by @bluegeek9
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 8last update
9 months ago Waiting for branch to pass - @bluegeek9 opened merge request.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 8last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 8last update
9 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 8last update
9 months ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
9 months ago 6:08pm 16 October 2023 - 🇺🇸United States bluegeek9
I also corrected phpcs, and eslint issues.
I left these two.
modules/puphpeteer/js/waitFor.js
80:20 error eval can be harmful no-eval
84:13 warning Unexpected console statement no-console
✖ 2 problems (1 error, 1 warning) - Status changed to Needs work
9 months ago 9:58pm 16 October 2023 - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 8last update
9 months ago Waiting for branch to pass - Status changed to Needs review
9 months ago 10:12pm 16 October 2023 - 🇺🇸United States bluegeek9
@markdorison,
I am okay with the exceptions you added. I don't know if you want to me or someone else to review the changes.
- Status changed to RTBC
8 months ago 3:11pm 25 October 2023 - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MySQL 8last update
8 months ago Waiting for branch to pass -
markdorison →
committed 9aaee6b4 on 2.x authored by
bluegeek9 →
Issue #3394399 by bluegeek9, markdorison: GitLab CI
-
markdorison →
committed 9aaee6b4 on 2.x authored by
bluegeek9 →
- Status changed to Fixed
8 months ago 3:13pm 25 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.