- Issue created by @yuvania
- 🇨🇷Costa Rica yuvania
This is a better version than the previous patch. The previous one improved the code but did not solve the problem of the deprecated method: implementsHook()
- Status changed to Needs work
about 1 year ago 2:35pm 16 October 2023 - 🇨🇭Switzerland berdir Switzerland
As commented on the other issue, there is no bug here, the call is in a condition that checks if the new method exists and only calls it if not.
What we can do is up the drupal core version we depend on to 9.4 and remove that condition, but that's a low-prio cleanup.
- 🇺🇸United States DamienMcKenna NH, USA
It's also worth noting that a lot of the patch focuses on test issues, not specifically the implementsHook() change.
- 🇨🇭Switzerland berdir Switzerland
True, we can keep those changes, but they aren't that important, nothing is actually broken, it's just recommended to make it protected now.
The proxy class changes on the other hand are wrong and must be reverted, rector does that all the time because it's confused about the generated proxy class code.