- Issue created by @dieterholvoet
- Status changed to Needs review
over 1 year ago 8:37am 20 October 2023 - 🇧🇪Belgium dieterholvoet Brussels
@weseze anything more I can do to help to get this commited?
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 2:20pm 14 March 2024 -
DieterHolvoet →
committed b830be6b on 2.x
Issue #3394299 by DieterHolvoet: Generated image styles are never...
-
DieterHolvoet →
committed b830be6b on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇧🇪Belgium weseze
Question on the change drimage.module.
Doesn't adding this line:use Drupal\imageapi_optimize\ImageAPIOptimizePipelineInterface;
create a dependency on the the "imageapi_optimize" module?
What happens if you don't have the module? Error or warning?
Also this function:
function drimage_imageapi_optimize_pipeline_update(ImageAPIOptimizePipelineInterface $entity): void { ... }
implies that the object "ImageAPIOptimizePipelineInterface" is availble and thus creates a dependency on an optional module.
Or am I wrong in this assumption?
- 🇧🇪Belgium dieterholvoet Brussels
No, it's okay to have use statements referencing non-existent classes in your code. It only causes errors when the code execution hits a reference to a non-existent class, but since
drimage_imageapi_optimize_pipeline_update
is never executed without the module installed this isn't a problem.