- Issue created by @reinfate
3 Patches with only fix, only test and both.
The test is only for BigPipe
@catch said ( https://www.drupal.org/project/drupal/issues/3377570#comment-15271705 📌 Add PHP Fibers support to BigPipe RTBC ) that it is not testable, and I've never written tests before, so I'm unsure how bad is it.
I could look at a separate test for Renderer if needed.- Status changed to Needs review
about 1 year ago 9:03pm 13 October 2023 - last update
about 1 year ago CI error - last update
about 1 year ago CI error - last update
about 1 year ago CI error - 🇬🇧United Kingdom catch
I take my words back, looks like it is testable after all and that's a nice test.
Only thing I might consider is defining the class with the lazy builder callback in the unit test itself (i.e. just defining the class at the bottom of the file alongside the test class), rather than putting it in the big pipe module controller which is more for functional tests.
- last update
about 1 year ago 30,398 pass - last update
about 1 year ago 30,397 pass, 1 fail The last submitted patch, 2: 3394062-fibers-suspend-loop-test.patch, failed testing. View results →
- last update
about 1 year ago Custom Commands Failed - @reinfate opened merge request.
Done
Moved the lazy builder callback to the unit test file in MR5009- last update
about 1 year ago 30,412 pass - Status changed to RTBC
about 1 year ago 1:46pm 19 October 2023 - 🇺🇸United States smustgrave
Leaning on test-only fail in #2 to show this issue.
Pointer from @catch in #4, from my understanding, has been addressed.
Think this is good to move ahead.
- last update
about 1 year ago 30,418 pass 8:54 34:40 Running- Status changed to Fixed
about 1 year ago 6:15am 21 October 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked back to 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.